Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For a 0.20 release #751

Merged
merged 47 commits into from
Apr 5, 2022
Merged

For a 0.20 release #751

merged 47 commits into from
Apr 5, 2022

Conversation

ablaom
Copy link
Member

@ablaom ablaom commented Mar 25, 2022 •
edited
Loading

ablaom and others added 30 commits January 21, 2022 15:41
@ablaom
drop filename arg from save(filename, model, ...)
5c83035
@ablaom
drop filenmame arguement from restore
009b439
@pazzo83
remove specific model checks for general scitype check
f39263e
@pazzo83
revert back to check for elscitype in passed-in args
3b85789
@ablaom
Merge pull request #724 from JuliaAI/drop-filename-from-save-method
4b272fe 
Drop `filename` arg from save(filename, model, ...)
@ablaom
Merge branch 'for-a-0-point-20-release' of https://github.com/alan-tu…
d231edc 
…ring-institute/MLJBase.jl into for-a-0-point-20-release
@olivierlabayle
correct save call with kwars...
c131aa8
@ablaom
address some MultivariateStats dep warnings
406f22a
@ablaom
fix logic with Unknown in fit_data_scitype, logging tests, misc
5c9eda4
@olivierlabayle
migrate current state from MLJSerialization
9f6bcdb
@olivierlabayle
add filesize check for composite
02a42b5
@olivierlabayle
add some Misc tests
10d9194
@olivierlabayle
add some docstrings
4b58488
@olivierlabayle
add UnupervisedModel test
6dd7270
@olivierlabayle
add warn message when loading machine with state != -1
25100d3
@olivierlabayle
refactor Base.replace to use in save
3581923
@olivierlabayle
add docstrings
a8c260c
@ablaom
drop filename arg from save(filename, model, ...)
6a08fd1
@ablaom
drop filenmame arguement from restore
feab9da
@olivierlabayle @ablaom
correct save call with kwars...
6bbcbb8
@ablaom
Merge branch 'for-a-0-point-20-release' of https://github.com/alan-tu…
b87339a 
…ring-institute/MLJBase.jl into for-a-0-point-20-release
@olivierlabayle
remove simple_data
5fde0b1
@olivierlabayle
update some docstrings
dbca31c
@olivierlabayle
move network_model_names to CompositeFitresult and remove report_addi…
8270e33 
…tions field from it
@olivierlabayle
update backquotes and old syntax
f5429ab
@olivierlabayle
switching to a undefined cache for serializable machines
d488717
@olivierlabayle
remove passing args to machine constructor from file
c91a810
@olivierlabayle
add restore! now sets state to 1
6d83802
@olivierlabayle
add warning deserialized for operations with args
03a74e0
@olivierlabayle
correct code to unbreak test but I believe the test itself is broken
69303a0
olivierlabayle and others added 12 commits February 3, 2022 13:00
@olivierlabayle
add another warning test
6a32f25
@ablaom
Merge branch 'dev' into for-a-0-point-20-release
348f82e
@pazzo83 @ablaom
remove specific model checks for general scitype check
8a28b43
@pazzo83 @ablaom
revert back to check for elscitype in passed-in args
61da705
@ablaom
address some MultivariateStats dep warnings
07784ab
@ablaom
fix logic with Unknown in fit_data_scitype, logging tests, misc
f808a66
@ablaom
Merge branch 'refactor_model_scitype_check2' of https://github.com/al…
d5c6462 
…an-turing-institute/MLJBase.jl into refactor_model_scitype_check2
@ablaom
remove redundant code
75f992d
@ablaom
improvement to warn_generic_scitype_mismatch()
f4be7dc
@ablaom
Merge pull request #732 from JuliaAI/refactor_model_scitype_check2
3f5229b 
Refactor model scitype check2
@ablaom
Merge pull request #733 from JuliaAI/serialization
51862ec 
Serialization
@ablaom
Merge branch 'dev' into for-a-0-point-20-release
aa53c2e
@ablaom ablaom marked this pull request as draft March 25, 2022 06:25
@ablaom ablaom marked this pull request as ready for review April 4, 2022 21:11
@ablaom ablaom changed the title [DO NOT MERGE] For a 0 point 20 release For a 0.20 release Apr 4, 2022
@ablaom ablaom mentioned this pull request Apr 4, 2022
Closed
9 tasks
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #751 (54eac32) into dev (cb6122f) will increase coverage by 0.30%.
The diff coverage is 98.33%.

@@            Coverage Diff             @@
##              dev     #751      +/-   ##
==========================================
+ Coverage   85.10%   85.41%   +0.30%     
==========================================
  Files          36       36              
  Lines        3398     3435      +37     
==========================================
+ Hits         2892     2934      +42     
+ Misses        506      501       -5
Impacted Files Coverage Δ
src/MLJBase.jl 60.00% <ø> (ø)
src/interface/model_api.jl 71.42% <66.66%> (+4.76%) ⬆️
src/machines.jl 86.66% <97.72%> (+2.64%) ⬆️
src/composition/learning_networks/machines.jl 91.95% <100.00%> (+1.59%) ⬆️
src/composition/models/inspection.jl 100.00% <100.00%> (ø)
src/composition/models/methods.jl 100.00% <100.00%> (ø)
src/operations.jl 84.37% <100.00%> (+1.04%) ⬆️
src/measures/confusion_matrix.jl 91.50% <0.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb6122f...54eac32. Read the comment docs.

@ablaom ablaom merged commit af1dc5b into dev Apr 5, 2022
@ablaom ablaom deleted the for-a-0-point-20-release branch April 5, 2022 23:12
@ablaom ablaom mentioned this pull request Apr 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ablaom @codecov-commenter @pazzo83 @olivierlabayle