Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major revision to simplify; in particular, to remove obsfit, obspredict, obstransform #30

Merged
merged 27 commits into from
Oct 2, 2024
Merged
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b60fc22
simplify, removing in particular, obsfit, obspredict, obstransform
ablaom May 19, 2024
d47cabe
rm redundant pkg from [extras]
ablaom May 19, 2024
f0c68d5
fix typos
ablaom May 19, 2024
3252e09
more doc tweaks
ablaom May 20, 2024
69bd859
fix table of contents for the docs
ablaom May 28, 2024
f4b0fdd
tweak
ablaom May 28, 2024
acac24f
doc tweak
ablaom May 28, 2024
3b289f5
tweak
ablaom May 28, 2024
d6c320f
whitespace fixes
ablaom May 28, 2024
54a5f9b
fix whitespace
ablaom May 28, 2024
0af5476
clarify importance of constructor over type in traits and docstrings
ablaom May 30, 2024
4b7c09c
add Expectile and Quantile target proxy types
ablaom Jun 13, 2024
82ade40
add target_observation_scitype
ablaom Sep 8, 2024
7a781a0
more doc updates
ablaom Sep 24, 2024
31c42c6
add fallbacks to reduce need to overload some convenience methods
ablaom Sep 26, 2024
79c67e3
add fallbacks to rm need for overloading predict convenience fn
ablaom Sep 26, 2024
d270229
add some forgotten files
ablaom Sep 26, 2024
6e721c8
doc updates and some small re-organziation of code
ablaom Sep 26, 2024
729e0d7
complete addition of update methods + other tweaks
ablaom Oct 1, 2024
20b4bff
rename fit.* -> fit_update.* and descriptors -> tags
ablaom Oct 1, 2024
1a92f47
tweak
ablaom Oct 1, 2024
d1f3259
teak target_observation_scitype
ablaom Oct 1, 2024
d69c5b0
purge a bunch of traits related to predict/transform input/output
ablaom Oct 1, 2024
11b38cf
rename LiteralTarget -> Point
ablaom Oct 1, 2024
8fd02c9
fix typos
ablaom Oct 2, 2024
60f8b6c
fix syntax error in test
ablaom Oct 2, 2024
e25e4e7
add julia 1.10 testing to matrix
ablaom Oct 2, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rm redundant pkg from [extras]
ablaom committed May 19, 2024

Verified

This commit was signed with the committer’s verified signature.
Trickfilm400 Trickfilm400
commit d47cabe03a50f236ae86c2e1a2aa46dd8b0ae149
1 change: 0 additions & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -14,7 +14,6 @@ DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
MLUtils = "f1d291b0-491e-4a28-83b9-f70985020b54"
Serialization = "9e88b42a-f829-5b0c-bbe9-9e923198166b"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"


Unchanged files with check annotations Beta

## Sample implementation
Refer to the "Anatomy of an Implemetation" section of the LearnAPI

Check warning on line 72 in src/obs.jl

GitHub Actions / Spell Check with Typos

"Implemetation" should be "Implementation".
[manual](https://juliaai.github.io/LearnAPI.jl/dev/).
```julia
obs(algorithm, data) # can be passed to `fit` instead of `data`
obs(model, data) # can be passed to `predict` or `tranform` instead of `data`

Check warning on line 11 in docs/src/obs.md

GitHub Actions / Spell Check with Typos

"tranform" should be "transform".
```
## Typical workflows
### The `obs` contract
Providing `fit` signatures matching the output of `obs`, is the first part of the `obs`
contract. The second part is this: *The outupt of `obs` must implement the*

Check warning on line 404 in docs/src/anatomy_of_an_implementation.md

GitHub Actions / Spell Check with Typos

"outupt" should be "output".
[MLUtils.jl](https://juliaml.github.io/MLUtils.jl/dev/) `getobs/numobs` *interface for
accessing individual observations*. It usually suffices to overload `Base.getindex` and
`Base.length` (which are the `getobs/numobs` fallbacks):