Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in docs, match docs with README, add downgrade check #31

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

tylerjthomas9
Copy link
Collaborator

@tylerjthomas9 tylerjthomas9 commented Feb 29, 2024

Fixed the example in the README and expanded the README/docs homepage to match each other.

I added a Downgrade action that checks the minimum bounds on all the compat entries (and fixed all the issues that came up).

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.55%. Comparing base (6d6ff0f) to head (27040cb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   75.55%   75.55%           
=======================================
  Files           6        6           
  Lines         180      180           
=======================================
  Hits          136      136           
  Misses         44       44           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't actually run the examples and assume you did.

Didn't know about the downgrade action. So, we run tests first using latest deps, and then again using latest Julia and oldest deps compatible with bounds in Project?

@ablaom
Copy link
Member

ablaom commented Feb 29, 2024

Assuming this closes #30, yes?

@tylerjthomas9
Copy link
Collaborator Author

Looks good to me. I didn't actually run the examples and assume you did.

I somehow missed the one in the readme. It's the same one from the examples folder that we run in the tests.

Didn't know about the downgrade action. So, we run tests first using latest deps, and then again using latest Julia and oldest deps compatible with bounds in Project?

Yes, the downgrade action just runs the tests with the lower bounds of each dependency. https://www.stochasticlifestyle.com/semantic-versioning-semver-is-flawed-and-downgrade-ci-is-required-to-fix-it/

@tylerjthomas9
Copy link
Collaborator Author

Assuming this closes #30, yes?

Yes

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏🏾

@tylerjthomas9 tylerjthomas9 merged commit 28930d4 into JuliaAI:main Feb 29, 2024
9 of 10 checks passed
@tylerjthomas9 tylerjthomas9 deleted the docs-downgrade branch December 15, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants