-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example in docs, match docs with README, add downgrade check #31
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
=======================================
Coverage 75.55% 75.55%
=======================================
Files 6 6
Lines 180 180
=======================================
Hits 136 136
Misses 44 44 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I didn't actually run the examples and assume you did.
Didn't know about the downgrade action. So, we run tests first using latest deps, and then again using latest Julia and oldest deps compatible with bounds in Project?
Assuming this closes #30, yes? |
I somehow missed the one in the readme. It's the same one from the examples folder that we run in the tests.
Yes, the downgrade action just runs the tests with the lower bounds of each dependency. https://www.stochasticlifestyle.com/semantic-versioning-semver-is-flawed-and-downgrade-ci-is-required-to-fix-it/ |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏🏾
Fixed the example in the README and expanded the README/docs homepage to match each other.
I added a Downgrade action that checks the minimum bounds on all the compat entries (and fixed all the issues that came up).