Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.5 #28

Merged
merged 69 commits into from
Mar 23, 2023
Merged

Version 1.5 #28

merged 69 commits into from
Mar 23, 2023

Conversation

TureBentzin
Copy link
Member

  • bugfixes
  • setIfAbsent for Configurations
  • Create ObjectHashtableToStringHashtableMapper.java
  • further steps for the CoreCacheAPI
  • Breaking: Minigames now autostart!! (Experimental)
  • fixed Stackwalker for MiniGame error logging
  • some experiments with error-prone

TureBentzin and others added 27 commits February 28, 2023 17:02
@TureBentzin
bump 1.5-SNAPSHOT
7896084
@TureBentzin
Delete identifier.sqlite
940674a
@TureBentzin
Update FallBackMessage.java
4852430
@TureBentzin
Delete ApiIntegrityTest.java
7e2c7c0
@TureBentzin
remove debugs
d9d58a5 
sorry
@TureBentzin
add setIfAbsent
ad4d14b
@TureBentzin
Update Configuration.java
07d1e3a
@TureBentzin
fix naming
6c01f9a
@TureBentzin
Create ObjectHashtableToStringHashtableMapper.java
09482d7
@TureBentzin
add OfflineConfiguration to API
8a45e7e
@TureBentzin
Update CoreCacheApi.java
f1f9424
@TureBentzin
deprecate doWithData
1413ec8
@TureBentzin
add core check to API.get()
1e17791
@TureBentzin
add autostart to minigames
8af9f4e
@TureBentzin
fix #27
e5e1eb9
@TureBentzin
fix StackWalker bug
f4615d4
@TureBentzin
fixed isses with the APIProvider
4fc161f
@TureBentzin
add errorprone
5a7b8cd
@TureBentzin
add PreDefinedInsertionProcedure
e16f498
@TureBentzin
start fixing the SwitchingInsertionProcedure
5c80025
@TureBentzin
add javadoc
f9e1b68
@TureBentzin
add createSectionClone and new Interpreters
c68b65b
@TureBentzin
add Environment and Property Interpreter
c564eae
@TureBentzin
upgrade environment interpreter
776bf38
@TureBentzin
move dir
d05c4d1
@TureBentzin
Create HazelFeedMapInterpreter.java
7ccf4db
@TureBentzin
add customPropertyInterpreter
f740ff2
@TureBentzin
Copy link
Member Author

I'm currently thinking about giving the MiniGame the ability to set a "startType" of some sort to make it easier to build MiniGames that are powered by a "LobbyPhase" and such ones that are running all the time and need to be started directly after the MiniGame was successfully loaded.

Currently the MiniGameAPI is not used over a wide range of projects, so it would be possible to make a breaking change.

Also i need to rethink the direct native integration of TimoCloud into the MiniGameAPI, maybe there should be a better way to integrate own and custom cloud systems into the communication and state providing service that is handled and managed by the MiniGame API. The API has currently only limited information about the MiniGame (There should be improvements). It should be possible to access the MiniGame and control it, also if the controller does not implement or know the (or a) MiniGameAPI.

If further support for different CloudSystems is implemented native into the Core (what is unlikely) then CloudNet2 and CloudNet3 need a native implementation. Other CloudSystems would need more research on their users and their features to allow them to be implemented into the Communication and State Provider Technology that is used by the MiniGameAPI to inform other Servers, Services and the Players about the current "state" the MiniGame is in.

TureBentzin
TureBentzin commented Mar 17, 2023
View reviewed changes
Copy link
Member Author

@TureBentzin TureBentzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some additional information for the review process

API/src/main/java/net/juligames/core/api/config/BuildInInterpreters.java Show resolved Hide resolved
API/src/main/java/net/juligames/core/api/config/ConfigurationAPI.java Show resolved Hide resolved
API/src/main/java/net/juligames/core/api/config/mapbacked/DictionaryFeedInterpreter.java Show resolved Hide resolved
HazelAPI/src/main/java/net/juligames/core/api/hazel/HazelObjectInterpreter.java Show resolved Hide resolved
HazelAPI/src/main/java/net/juligames/core/api/hazel/NativeHazelDataAPI.java Show resolved Hide resolved
...c/main/java/net/juligames/core/minigame/api/team/procedures/SwitchingInsertionProcedure.java Outdated Show resolved Hide resolved
Bommels05
Bommels05 requested changes Mar 18, 2023
View reviewed changes
Copy link
Contributor

@Bommels05 Bommels05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you by now know what I would write here... Good Work and a few things to fix

API/src/main/java/net/juligames/core/api/config/Configuration.java Show resolved Hide resolved
API/src/main/java/net/juligames/core/api/config/ConfigurationAPI.java
* @param section the section
* @return an OfflineConfiguration. Changes to this will not affect root
*/
@ApiStatus.AvailableSince("1.5")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is in testing I would add a @ Experimental Annotation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not only for testing, but also for storing data temporarily or working with a local dataset. There are a lot of possibilities!

API/src/main/java/net/juligames/core/api/config/mapbacked/DictionaryFeedInterpreter.java Outdated Show resolved Hide resolved
API/src/main/java/net/juligames/core/api/config/mapbacked/EnvironmentVariable.java Show resolved Hide resolved
API/src/main/java/net/juligames/core/api/config/mapbacked/HazelFeedMapInterpreter.java Show resolved Hide resolved
API/src/main/java/net/juligames/core/api/minigame/StartType.java Show resolved Hide resolved
API/src/main/java/net/juligames/core/api/minigame/BasicMiniGame.java Outdated Show resolved Hide resolved
Core/src/main/java/net/juligames/core/caching/CoreCacheApi.java Outdated Show resolved Hide resolved
Core/src/main/java/net/juligames/core/config/CoreConfiguration.java Outdated Show resolved Hide resolved
MiniGameAPI/src/main/java/net/juligames/core/minigame/api/MiniGame.java Outdated Show resolved Hide resolved
TureBentzin and others added 12 commits March 18, 2023 15:18
@TureBentzin @Bommels05
Update API/src/main/java/net/juligames/core/api/minigame/BasicMiniGam…
a21c937 
…e.java

Co-authored-by: Bommels05 <[email protected]>
@TureBentzin @Bommels05
Update Core/src/main/java/net/juligames/core/config/CoreConfiguration…
6054931 
….java

Co-authored-by: Bommels05 <[email protected]>
@TureBentzin @Bommels05
Update MiniGameAPI/src/main/java/net/juligames/core/minigame/api/Mini…
8cb34c9 
…Game.java

Co-authored-by: Bommels05 <[email protected]>
@TureBentzin
Update API/src/main/java/net/juligames/core/api/config/BuildInInterpr…
0fa586e 
…eters.java
@TureBentzin
Update API/src/main/java/net/juligames/core/api/config/ConfigurationA…
caf4d1c 
…PI.java
@TureBentzin
Update API/src/main/java/net/juligames/core/api/config/mapbacked/Dict…
ccb7980 
…ionaryFeedInterpreter.java
@TureBentzin
fix #30
d2d32d3 
removed the log entry that leaked the database credentials
@TureBentzin
fixed compiler issue
4f375be
@TureBentzin
fixed second compiler issue
acb4f0b
@TureBentzin
Update SwitchingInsertionProcedure.java
c13c820
@TureBentzin
Merge branch 'development' of https://github.com/JuliGames/JuliGamesCore
1a9993c 
 into development
@TureBentzin
some reformat
dbdaa04
@TureBentzin TureBentzin mentioned this pull request Mar 22, 2023
Closed
@TureBentzin TureBentzin requested a review from Bommels05 March 22, 2023 16:01
Bommels05
Bommels05 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@Bommels05 Bommels05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TureBentzin TureBentzin merged commit 2873eea into main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bommels05 Bommels05 Bommels05 approved these changes

Assignees
No one assigned
Labels
bStats This is related to the collection of data with bStats Configuration Feature Removed This PR will remove a feature MessageSystem New Feature New Version This PR will update a version Paper Priority: High Waiting for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TureBentzin @Bommels05