Add device posture test driver and web platform tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakuco
reviewed
Feb 19, 2024
rakuco
requested changes
Feb 21, 2024
Missing newline from tools/wptrunner/wptrunner/executors/protocol.py. Remove comma from resources/testdriver.js. Unused commented code in device-posture/device-posture.https.html.
Removed the requirement from all tests to set up cleanup function. All tests are now wrapped around device_posture_test call. This enables that adding of cleanup function for each test is done in one location.
Two tests where similar, so other was delete.
EventWatcher promise was waited with mixed style. Code was fixed to use only one style of waiting. After change EventWatcher eventTypes parameter value needed to change also to able to run test correctly.
JuhaVainio
changed the title
Also added rest of the parameters which display-feature needs.
JuhaVainio
commented
Mar 28, 2024
JuhaVainio
commented
Mar 28, 2024
JuhaVainio
changed the title
…trunner/executors/executormarionette.py
…r.py Every other class name has "Protocol" word
rakuco
reviewed
Apr 5, 2024
Event type was changed from 'onchange' to 'change'. This led change in waiting for event. Which solved the problem that 'continuous' posture had to be the first posture.
Removed because other tests already had same code and read posture through navigator.devicePosture.type.
rakuco
reviewed
Apr 19, 2024
There was a problem hiding this comment.
One thing that's just occurred to me while working on the content_shell CL upstream: all these tests that call set_device_posture() need a
t.add_cleanup(async () => {
await test_driver.clear_device_posture();
});call to make sure nothing leaks between tests.
JuhaVainio
pushed a commit
that referenced
this pull request
Jun 25, 2024
Since @page border box layout objects aren't in the the layout tree, any code that wants to walk up the tree to find the containing block will be in for a surprise. This would happen if percentage-based @page padding was used [1]. Recomputing padding during painting when we have already done it during layout is rather pointless anyway. Read it out directly from the fragment. [1] #1 blink::LayoutBox::ContainingBlockLogicalWidthForContent() #2 blink::LayoutBoxModelObject::ComputedCSSPadding() #3 blink::LayoutBoxModelObject::PaddingTop() #4 blink::LayoutBoxModelObject::PaddingOutsets() web-platform-tests#5 blink::BoxPainterBase::PaintFillLayer() web-platform-tests#6 blink::BoxPainterBase::PaintFillLayers() web-platform-tests#7 blink::BoxFragmentPainter::PaintBackground() Bug: 40286153 Change-Id: I1e6e92c2ce1d81aab2673ec9a877eac455534102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5526469 Commit-Queue: Morten Stenshorne <[email protected]> Reviewed-by: Xianzhu Wang <[email protected]> Reviewed-by: Ian Kilpatrick <[email protected]> Cr-Commit-Position: refs/heads/main@{#1300711}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.