Rename appearance:bikeshed to appearance:base-select

appearance:bikeshed is getting negative feedback for prototyping, so I am renaming it to base-select even though we don't know that it will be the final name yet. Bug: 1511354 Change-Id: I9b6bc228916c8f25af54009644ad135685c7aed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5421872 Reviewed-by: Philip Jägenstedt <[email protected]> Commit-Queue: Philip Jägenstedt <[email protected]> Reviewed-by: David Baron <[email protected]> Cr-Commit-Position: refs/heads/main@{#1283005}
JuhaVainio · Apr 5, 2024 · d49e524 · d49e524
1 parent 0434697
commit d49e524
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/...select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html b/...select-element/stylable-select/select-appearance-custom-button-no-datalist.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <button type=popover>one</button>
   <option>one</option>
   <option>two</option>

diff --git a/...select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html b/...select-element/stylable-select/select-appearance-no-button-custom-datalist.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <datalist>
     <option>one</option>
     <option>two</option>

diff --git a/...the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html b/...the-select-element/stylable-select/select-appearance-no-button-no-datalist.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver.js"></script>
 <script src="/resources/testdriver-vendor.js"></script>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <option>one</option>
   <option>two</option>
 </select>

diff --git a/...lect-element/stylable-select/select-child-button-and-datalist-invalidation.tentative.html b/...lect-element/stylable-select/select-child-button-and-datalist-invalidation.tentative.html
@@ -25,7 +25,7 @@
 
 <script>
 requestAnimationFrame(() => {
-  document.querySelector('select').style = 'appearance:bikeshed';
+  document.querySelector('select').style = 'appearance:base-select';
   document.querySelector('button').click();
   document.documentElement.classList.remove('reftest-wait');
 });

diff --git a/.../forms/the-select-element/stylable-select/select-child-button-and-datalist.tentative.html b/.../forms/the-select-element/stylable-select/select-child-button-and-datalist.tentative.html
@@ -10,7 +10,7 @@
 }
 </style>
 
-<select style="appearance:bikeshed">
+<select style="appearance:base-select">
   <button type=popover>button</button>
   <datalist>
     <option>

diff --git a/...emantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html b/...emantics/forms/the-select-element/stylable-select/select-keyboard-behavior.tentative.html
@@ -11,7 +11,7 @@
 
 <style>
 select {
-  appearance: bikeshed;
+  appearance: base-select;
 }
 </style>
 

diff --git a/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html b/html/semantics/forms/the-select-element/stylable-select/select-mouse-behavior.tentative.html
@@ -11,7 +11,7 @@
 
 <style>
 select {
-  appearance: bikeshed;
+  appearance: base-select;
 }
 </style>
 
@@ -41,7 +41,7 @@
   await test_driver.click(button);
   assert_false(select.matches(':open'),
     'Select should be closed after clicking the button a second time.');
-}, 'Select with appearance:bikeshed should open and close when clicking the button.');
+}, 'Select with appearance:base-select should open and close when clicking the button.');
 
 promise_test(async () => {
   assert_false(select.matches(':open'),
@@ -58,5 +58,5 @@
     'Select should be closed after clicking an option.');
   assert_equals(select.value, 'two',
     'Select.value should be two after clicking the option.');
-}, 'Clicking an option in an appearance:bikeshed select should choose the option and close the popover.');
+}, 'Clicking an option in an appearance:base-select select should choose the option and close the popover.');
 </script>
diff --git a/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html b/html/semantics/forms/the-select-element/stylable-select/selectedoption.tentative.html
@@ -7,7 +7,7 @@
 <script src="/resources/testdriver-vendor.js"></script>
 
 <form>
-  <select style="appearance:bikeshed">
+  <select style="appearance:base-select">
     <button>
       <selectedoption></selectedoption>
     </button>