Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sophomore page #20

Closed
wants to merge 1 commit into from
Closed

Added sophomore page #20

wants to merge 1 commit into from

Conversation

jay-deep
Copy link

@jay-deep jay-deep commented Oct 4, 2020

Bro I've added sophomore
at 25%
at 100%

page as u assigned, but there's some one issue in code, when u zoom out ur screen to 25% Then the page will get displayed perfectly, I am working on this issue but till then Check the code and and tell me what should I update
issue no #3

Bro I've added sophmore page as u assigned, but there's some one issue in code, when u zoom out ur screen to 25% Then the page will get displayed perfectly, I am working on this issue but till then Check the code and and tell me what should I update
issue no #2
@decon-harsh
Copy link
Member

decon-harsh commented Oct 4, 2020

Checking this out ! No need to add instagram icon that was just a refrence no prob i will edit it!

@decon-harsh
Copy link
Member

decon-harsh commented Oct 4, 2020

There is padding of 4000px and 700 px

@decon-harsh
Copy link
Member

Cannot merge this, this needs more work, Nice attempt @jay-deep . Do reduce the margins, paddings, take help from index.html, freshers.html, and css files.

@jay-deep
Copy link
Author

jay-deep commented Oct 5, 2020

yes bro , will send u again after correcting it

@decon-harsh
Copy link
Member

yes bro , will send u again after correcting it

If you commit changes in your fork , it will automatically change here.

@jay-deep
Copy link
Author

jay-deep commented Oct 5, 2020

I am writing css again , in my vs code , then will change in my fork

jay-deep pushed a commit to jay-deep/home that referenced this pull request Oct 5, 2020
Bro , Now check it, is it fine?
Will definitely enhance the css but main thing is code, I tried so hard , You assigned me so literally I dont wanted to let u down, Plz inform me the errors in this.
JsrEntity#20
@jay-deep jay-deep mentioned this pull request Oct 5, 2020
@decon-harsh
Copy link
Member

decon-harsh commented Oct 6, 2020

Sorry i was busy didn't see the new commits. My fault

I will check it asap

Next time if you make new commit please drop a message below it , easy for me to get notifications.

@jay-deep
Copy link
Author

jay-deep commented Oct 6, 2020

ohh , okok no problem, and bro can u add "hactobefest" label in ur topic?

@decon-harsh
Copy link
Member

ohh , okok no problem, and bro can u add "hactobefest" label in ur topic?

I guess it's already added doesn't it? I will add the issue labels too.

@jay-deep
Copy link
Author

jay-deep commented Oct 6, 2020

This is the new rule of hactoberfest
"Your pull requests will count toward your participation if they are in a repository with the hacktoberfest topic and once they have been merged, approved by a maintainer or labelled as hacktoberfest-accepted."
I didn't get it, can u explain me a little bit?

@decon-harsh
Copy link
Member

Can you go to hacktober website and then login to your profile . Is this pr in maturity period?

@jay-deep
Copy link
Author

jay-deep commented Oct 6, 2020

Yes , 10days
See, I don't understand this
Screenshot (24)
And these are the new rules of hacktober fest
rules

@decon-harsh
Copy link
Member

These rules are for PR after 3rd oct 00:00,

The time period i.e maturity period is the the time for us maintainers to check whether a PR is useful or not . Since your last PR no 20 cannot be merged and you opened a new PR 21 i have to close the former . That won't be counted for the hacktober fest.

@decon-harsh decon-harsh closed this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants