-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added sophomore page #20
Conversation
Bro I've added sophmore page as u assigned, but there's some one issue in code, when u zoom out ur screen to 25% Then the page will get displayed perfectly, I am working on this issue but till then Check the code and and tell me what should I update issue no #2
Checking this out ! No need to add instagram icon that was just a refrence no prob i will edit it! |
There is padding of 4000px and 700 px |
Cannot merge this, this needs more work, Nice attempt @jay-deep . Do reduce the margins, paddings, take help from index.html, freshers.html, and css files. |
yes bro , will send u again after correcting it |
If you commit changes in your fork , it will automatically change here. |
I am writing css again , in my vs code , then will change in my fork |
Bro , Now check it, is it fine? Will definitely enhance the css but main thing is code, I tried so hard , You assigned me so literally I dont wanted to let u down, Plz inform me the errors in this. JsrEntity#20
Sorry i was busy didn't see the new commits. My fault I will check it asap Next time if you make new commit please drop a message below it , easy for me to get notifications. |
ohh , okok no problem, and bro can u add "hactobefest" label in ur topic? |
I guess it's already added doesn't it? I will add the issue labels too. |
This is the new rule of hactoberfest |
Can you go to hacktober website and then login to your profile . Is this pr in maturity period? |
These rules are for PR after 3rd oct 00:00, The time period i.e maturity period is the the time for us maintainers to check whether a PR is useful or not . Since your last PR no 20 cannot be merged and you opened a new PR 21 i have to close the former . That won't be counted for the hacktober fest. |
Bro I've added sophomore
page as u assigned, but there's some one issue in code, when u zoom out ur screen to 25% Then the page will get displayed perfectly, I am working on this issue but till then Check the code and and tell me what should I update
issue no #3