-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project system #23
Draft
JoshuaMKW
wants to merge
140
commits into
master
Choose a base branch
from
project-system
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Project system #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HazardousPeach
force-pushed
the
project-system
branch
from
September 17, 2024 23:25
7a5efc5
to
59534ee
Compare
The fs_icon_path variable is never used in this function, and validateIndex is called at the top of the function and won't let the rest run if it returns false.
Is just visual so far though, can't do anything with it.
Also, it turns out there was already a member variable for tracking the selection, so remove the one I added and use that instead.
…Toolbox into project-system
* Outline new item window * Fix wrong file modified * Some things * Idk more stuff * Update gitignore * Button behavior is underlaying? * Fix rendering issues * Add idea of context path for convenient saving * Adjust code
JoshuaMKW
commented
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds project awareness and interaction.