Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove semver dependency #587

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Nov 25, 2024

PR Checklist

Overview

@fisker fisker mentioned this pull request Nov 25, 2024
3 tasks
@fisker fisker marked this pull request as ready for review November 25, 2024 15:01
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good improvement in addition to / in parallel to #576. Even once the build is fixed to not bundle semver, reducing dependencies is a 👍 from me. Filed #589.

@JoshuaKGoldberg JoshuaKGoldberg changed the title build: reduce package size feat: remove semver dependency Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (b7397b9) to head (de0cfd2).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
+ Coverage   80.74%   80.89%   +0.15%     
==========================================
  Files          35       35              
  Lines        6663     6663              
  Branches      445      448       +3     
==========================================
+ Hits         5380     5390      +10     
+ Misses       1283     1273      -10     
Flag Coverage Δ
4.3.5 79.67% <50.00%> (?)
4.6.4 79.70% <50.00%> (?)
4.9.5 79.70% <50.00%> (ø)
latest 80.48% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RebeccaStevens RebeccaStevens changed the title feat: remove semver dependency build: remove semver dependency Nov 26, 2024
@RebeccaStevens RebeccaStevens enabled auto-merge (squash) November 26, 2024 04:19
@RebeccaStevens RebeccaStevens merged commit 8cec962 into JoshuaKGoldberg:main Nov 26, 2024
24 checks passed
@fisker fisker deleted the remove-semve branch November 26, 2024 04:21
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @fisker for infra.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @fisker! 🎉

@JoshuaKGoldberg
Copy link
Owner

oh keeping on build: won't trigger a new release... yes!

@RebeccaStevens
Copy link
Collaborator

I didn't want to release a new built without #576 first also being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Remove dependency on semver
3 participants