Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make isFalsyType() return true for 0n #545

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: make isFalsyType() return true for 0n #545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e37c8e8
check for falsiness of 0n
kirkwaiblinger Oct 27, 2024
0d819d3
work around bug for old TS versions
kirkwaiblinger Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/types/utilities.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,9 @@
[true, "false"],
[true, "0"],
[true, "null"],
[true, "0n"],
[true, "-0n"],
[false, "24n"],
])("returns %j when given %s", (expected, source) => {
const { sourceFile, typeChecker } = createSourceFileAndTypeChecker(`
${source};
Expand All @@ -180,7 +183,7 @@
const node = sourceFile.statements.at(-1) as ts.ExpressionStatement;
const type = typeChecker.getTypeAtLocation(node.expression);

expect(isFalsyType(type)).toBe(expected);

Check failure on line 186 in src/types/utilities.test.ts

View workflow job for this annotation

GitHub Actions / test (18.x, 4.3.5)

src/types/utilities.test.ts > isFalsyType > returns true when given 0n 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ src/types/utilities.test.ts:186:29

Check failure on line 186 in src/types/utilities.test.ts

View workflow job for this annotation

GitHub Actions / test (18.x, 4.3.5)

src/types/utilities.test.ts > isFalsyType > returns true when given -0n 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ src/types/utilities.test.ts:186:29

Check failure on line 186 in src/types/utilities.test.ts

View workflow job for this annotation

GitHub Actions / test (18.x, 4.6.4)

src/types/utilities.test.ts > isFalsyType > returns true when given 0n 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ src/types/utilities.test.ts:186:29

Check failure on line 186 in src/types/utilities.test.ts

View workflow job for this annotation

GitHub Actions / test (18.x, 4.6.4)

src/types/utilities.test.ts > isFalsyType > returns true when given -0n 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ src/types/utilities.test.ts:186:29

Check failure on line 186 in src/types/utilities.test.ts

View workflow job for this annotation

GitHub Actions / test (18.x, 4.9.5)

src/types/utilities.test.ts > isFalsyType > returns true when given 0n 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ src/types/utilities.test.ts:186:29

Check failure on line 186 in src/types/utilities.test.ts

View workflow job for this annotation

GitHub Actions / test (18.x, 4.9.5)

src/types/utilities.test.ts > isFalsyType > returns true when given -0n 

AssertionError: expected false to be true // Object.is equality

- Expected
+ Received

- true
+ false

 ❯ src/types/utilities.test.ts:186:29
});
});

Expand Down
6 changes: 5 additions & 1 deletion src/types/utilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ export function isFalsyType(type: ts.Type): boolean {
}

if (type.isLiteral()) {
return !type.value;
if (typeof type.value === "object") {
return type.value.base10Value === "0";
} else {
return !type.value;
}
}

return isFalseLiteralType(type);
Expand Down
Loading