fix: Fix argument parsing if params are present e.g. {RandomNumber(2,4)} #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled over the fact that the argument parsing seems to fail if the argument contains params.
Example:
When I fill in "field1" with "{RandomNumber(2,4)}"Will result in a value of "{RandomNumber(2,4)}" because
\Transformation\Argument::supportsDefinitionAndArgument()will not recognize the argument as valid "function".This is due to a to restrictive regexp in
\Transformation\Argument::SLOT_NAME_REGEX.This PR adjusts the related pattern and expands the test suite to catch this type of error.
If you run the test suite without the pattern adjustment it will fail, and it will completely pass once the pattern has been adjusted.