Feature [#35]: Add support for delete api #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement new `delete_api` method in `ApiService` struct - Implement new `delete_api` method in `Client` struct - Add new `DeleteApiRequest` struct as per Unkey Docs - Add new static variable `DELETE_API` - Add DocStrings to include usage and examples for new `delete_api` methods Refs: Jonxslays#38
|
From a glance this looks great. I'll merge and release after work tonight. Thanks for the contribution! |
Jonxslays
changed the title
|
I got another chance to look back at this today. The Delete API endpoint accepts a request body, not a query parameter - I fixed that for you. |
djnovin
added a commit
to djnovin/unkey
that referenced
this pull request
Dec 28, 2024
* feat: Add support for delete api (Jonxslays#38) --------- Co-authored-by: Jonxslays <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
cargo testand all tests pass.cargo fmtand the code is formatted.cargo clippyin pedantic mode and refactored.Related Issues