Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bindings not found #2324

Merged
merged 1 commit into from
May 7, 2024
Merged

fix: bindings not found #2324

merged 1 commit into from
May 7, 2024

Conversation

joanna-pagepro
Copy link
Contributor

Description

There's an error when I tried to run npm run frontend
image

The issue and suggested solutions can be found here: vitejs/vite-plugin-react-swc#74

Testing

I'm using Mac Sonoma 14.4.1

Diffs

New stuff ✨

  • @swc/core package

Changes 🏗

Deletions ⚰️

TODO

@joanna-pagepro joanna-pagepro self-assigned this May 6, 2024
@joanna-pagepro joanna-pagepro requested review from a team as code owners May 6, 2024 06:50
ArmandoGraterol
ArmandoGraterol approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@ArmandoGraterol ArmandoGraterol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected as far as I can notice. I also came across this error (Ventura OS) but my solution was to remove the node_modules + package-lock

@joanna-pagepro
Copy link
Contributor Author

@ArmandoGraterol The same solution works for me as well, but there were many changes in package-lock that could affect other packages, not related to this issue, and potentially break something else. I may be wrong, but if this solution is good let me know.

chmanie
chmanie approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@chmanie chmanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes it for me, too. Thanks @joanna-pagepro!

@chmanie chmanie merged commit 3602883 into master May 7, 2024
2 of 3 checks passed
@chmanie chmanie deleted the fix/bindings-not-found branch May 7, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArmandoGraterol ArmandoGraterol ArmandoGraterol approved these changes

@chmanie chmanie chmanie approved these changes

Assignees

@joanna-pagepro joanna-pagepro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joanna-pagepro @chmanie @ArmandoGraterol