Remove weakly_canonical and replace with Luau's normalisePath #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weakly_canonical performs filesystem calls to check if all components of the path exist, and resolve symlinks. We don't need these features. We replace with Luau's normalisePath. Note that weakly_canonical would also make relative file paths absolute by appending them to the current working directory. This cause relative string requires to break. We resolve this by making paths absolute in string requires - we shouldn't be relying on the current directory in the first place
We need to apply the rootUri prefix for file aliases too in case they were relative
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weakly_canonical performs filesystem calls to check if all components of the path exist, and resolve symlinks. We don't need these features.
We replace with Luau's normalisePath.
Note that weakly_canonical would also make relative file paths absolute by appending them to the current working directory. This cause relative string requires to break. We resolve this by making paths absolute in string requires - we shouldn't be relying on the current directory in the first place
Closes #856