Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't rename symbols #2

Open
someoneyouspite opened this issue Jul 8, 2024 · 2 comments · May be fixed by JohnnyMorganz/luau-lsp#732
Open

Can't rename symbols #2

someoneyouspite opened this issue Jul 8, 2024 · 2 comments · May be fixed by JohnnyMorganz/luau-lsp#732
Labels
enhancement New feature or request luau-lsp Requires changes to luau-lsp

Comments

@someoneyouspite
Copy link

I am unable to rename symbols at all with both F2 and editor: rename.
I am able to:

  • Rename symbols in Zed with other languages.
  • Rename symbols in VSCode and Neovim with luau-lsp.

I am using the Arch Linux distribution of Zed.
@kohltastrophe
Copy link

This happens on MacOS Sonoma 14.5 (23F79) as well.
The language server and zed both have no relevant logs with any information to help with debugging.

@4teapo
Copy link
Owner

4teapo commented Jul 29, 2024

This is caused by an incompatibility between luau-lsp and Zed: Zed only allows symbol renaming if the language server has the LSP capability textDocument/prepareRename, which luau-lsp doesn't have. I will probably file a PR to Zed to fix this soon.

@4teapo 4teapo linked a pull request Aug 9, 2024 that will close this issue
Open
@notpeter notpeter mentioned this issue Sep 2, 2024
Open
1 task
@4teapo 4teapo added enhancement New feature or request luau-lsp Requires changes to luau-lsp labels Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request luau-lsp Requires changes to luau-lsp
Projects
None yet
Milestone
No milestone
3 participants
@kohltastrophe @someoneyouspite @4teapo