Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to rename if prepareRename is not supported #16663

Open
1 task done
kohltastrophe opened this issue Aug 22, 2024 · 1 comment
Open
1 task done

Fallback to rename if prepareRename is not supported #16663

kohltastrophe opened this issue Aug 22, 2024 · 1 comment
Labels
bug [core label] language server failure Language server doesn't work as expected language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors

Comments

@kohltastrophe
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Even if a language server supports rename, if it doesn't support prepareRename it seems to silently fail the rename action from the user.

  1. Use a language server implementation that doesn't support prepareRename, luau-lsp for my example
  2. Try to rename a symbol with either F2 or editor: rename
  3. Notice nothing happens and nothing is logged to the lsp logs or zed logs

Expected result:
I expect it to allow me to rename the symbol like VSCode, Neovim, and numerous other text editors even if the server does not support prepareRename.

This may also be an issue if the language server doesn't support documentHighlight but I haven't done enough research to conclude this.

Environment

Zed: v0.149.3 (Zed)
OS: Linux Wayland arch unknown
Memory: 62.7 GiB
Architecture: x86_64
GPU: NVIDIA GeForce RTX 4070 || NVIDIA || 555.58.02

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@kohltastrophe kohltastrophe added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Aug 22, 2024
@kohltastrophe kohltastrophe changed the title Fallback to rename if prepareRename isn't supported Fallback to rename if prepareRename is not supported Aug 22, 2024
@notpeter notpeter added language An umbrella label for all programming languages syntax behaviors language server failure Language server doesn't work as expected language server An umbrella label for all language servers lua Lua programming language support and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Sep 2, 2024
@notpeter
Copy link
Member

notpeter commented Sep 2, 2024

See also:

@notpeter notpeter removed the lua Lua programming language support label Sep 2, 2024
@github-actions github-actions bot added admin read Pending admin review triage Maintainer needs to classify the issue labels Nov 5, 2024
@notpeter notpeter removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] language server failure Language server doesn't work as expected language server An umbrella label for all language servers language An umbrella label for all programming languages syntax behaviors
Projects
None yet
Development

No branches or pull requests

2 participants