Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to sort relations #29

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Option to sort relations #29

merged 2 commits into from
Jun 15, 2021

Conversation

JohnGiorgi
Copy link
Owner

@JohnGiorgi JohnGiorgi commented Jun 14, 2021

This PR adds a parameter to sort the order of relations according to order of first appearance. This is already happening by default, but it can now be toggled on and off. The primary motivation to turn it off is for ablation analysis.

Other changes

  • ♻️ Factored out the logic to download the corpus in bc5cdr.py and gda.py into their own function (_download_corpus).

TODO

@JohnGiorgi JohnGiorgi self-assigned this Jun 14, 2021
@JohnGiorgi JohnGiorgi added the enhancement New feature or request label Jun 14, 2021
@JohnGiorgi JohnGiorgi merged commit 40e3ebe into main Jun 15, 2021
@JohnGiorgi JohnGiorgi deleted the option-to-sort-rels branch January 3, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant