Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GDA command #19

Merged
merged 7 commits into from
May 2, 2021
Merged

Add GDA command #19

merged 7 commits into from
May 2, 2021

Conversation

JohnGiorgi
Copy link
Owner

@JohnGiorgi JohnGiorgi commented May 2, 2021

Overview

This PR adds a command that downloads and preprocesses the GDA corpus, seq2rel-ds preprocess gda. The GDA corpus is contains gene-disease associations and was created with distant supervision (see here for more information).

Other changes

  • ✨ Add a new argument, sort_ents to parse_pubtator that sorts entities according to their order of first appearance. This is important for methods like ours, which use traditional, order-sensitive loss functions.
  • ♻️ Arguments shared by query_pubtator and parse_pubtator are now passed as **kwargs.

TODO

  • Expand test coverage for parse_pubtator to include all of the edge cases, as well as all of the parameters to the function. Tracking in Add tests for parse_pubtator #18.

@JohnGiorgi JohnGiorgi merged commit 0a2337a into main May 2, 2021
@JohnGiorgi JohnGiorgi deleted the add-gda-command branch May 2, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant