Remove outdated Python2 code #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `six` package
Rotzbua
force-pushed
the
remove_python2_code
branch
from
8bebb8d
to
1849bc4
Compare
|
imagehash had Python 2 support much longer than other packages, and it helped a number of users stuck on ancient systems that do not receive updates. I had PRs from several people over the years trying to remove it and calling it outdated. Unfortunately it has basically become impossible to run CI against such old versions now. So I think we may have to go with the times and say goodbye to Python 2 support at this point and recommend the affected users to use old versions. |
|
Hi @Rotzbua, sorry for picking this up so late. I'd be happy to merge this, but I see that there is a conflict. Can you please fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
sixpackage