Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes gfortran issue on MacOS #258

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Fixes gfortran issue on MacOS #258

merged 6 commits into from
Sep 20, 2024

Conversation

sahiljhawar
Copy link
Contributor

please squash and merge, thank you!

@coveralls
Copy link

coveralls commented Aug 20, 2024 •
edited
Loading

Coverage Status

coverage: 56.327% (+0.2%) from 56.173%
when pulling 66b89c2 on sahiljhawar:mac-ci
into 8cc4c46 on JohannesBuchner:master.

@JohannesBuchner
Copy link
Owner

Can we make this future-proof somehow?

@JohannesBuchner
Copy link
Owner

is which gfortran not enough?

@sahiljhawar
Copy link
Contributor Author

sahiljhawar commented Aug 20, 2024 •
edited
Loading

No, there are multiple versions of Fortran ie 12, 13, 14. There can be definitely be some regex/sed trickery and always get the fortran without worrying about the version.

@JohannesBuchner JohannesBuchner mentioned this pull request Sep 20, 2024
Open
@JohannesBuchner
Copy link
Owner

Merging this for now, thank you

@JohannesBuchner JohannesBuchner merged commit de11af0 into JohannesBuchner:master Sep 20, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sahiljhawar @coveralls @JohannesBuchner