Skip to content

Commit

Permalink
Merge pull request #13 from Joaopmorais/Error
Browse files Browse the repository at this point in the history
Error
  • Loading branch information
Joaopmorais committed Feb 20, 2024
2 parents 67bc384 + 9cef91a commit fd57c7a
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 22 deletions.
10 changes: 4 additions & 6 deletions exercises/13_error_handling/errors1.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,12 @@
// Execute `rustlings hint errors1` or use the `hint` watch subcommand for a
// hint.

// I AM NOT DONE

pub fn generate_nametag_text(name: String) -> Option<String> {
pub fn generate_nametag_text(name: String) ->Result <String, String> {
if name.is_empty() {
// Empty names aren't allowed.
None

Err(format!("`name` was empty; it must be nonempty."))
} else {
Some(format!("Hi! My name is {}", name))
Ok(format!("Hi! My name is {}", name))
}
}

Expand Down
4 changes: 2 additions & 2 deletions exercises/13_error_handling/errors2.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@
// Execute `rustlings hint errors2` or use the `hint` watch subcommand for a
// hint.

// I AM NOT DONE


use std::num::ParseIntError;

pub fn total_cost(item_quantity: &str) -> Result<i32, ParseIntError> {
let processing_fee = 1;
let cost_per_item = 5;
let qty = item_quantity.parse::<i32>();
let qty = item_quantity.parse::<i32>()?;

Ok(qty * cost_per_item + processing_fee)
}
Expand Down
4 changes: 2 additions & 2 deletions exercises/13_error_handling/errors3.rs
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,10 @@
// Execute `rustlings hint errors3` or use the `hint` watch subcommand for a
// hint.

// I AM NOT DONE

use std::num::ParseIntError;

fn main() {
fn main() -> Result<(), ParseIntError> {
let mut tokens = 100;
let pretend_user_input = "8";

Expand All @@ -23,6 +22,7 @@ fn main() {
tokens -= cost;
println!("You now have {} tokens.", tokens);
}
Ok(())
}

pub fn total_cost(item_quantity: &str) -> Result<i32, ParseIntError> {
Expand Down
11 changes: 8 additions & 3 deletions exercises/13_error_handling/errors4.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
// Execute `rustlings hint errors4` or use the `hint` watch subcommand for a
// hint.

// I AM NOT DONE

#[derive(PartialEq, Debug)]
struct PositiveNonzeroInteger(u64);

Expand All @@ -17,7 +15,14 @@ enum CreationError {
impl PositiveNonzeroInteger {
fn new(value: i64) -> Result<PositiveNonzeroInteger, CreationError> {
// Hmm... Why is this always returning an Ok value?
Ok(PositiveNonzeroInteger(value as u64))
if value<0{
Err(CreationError::Negative)
} else if value ==0 {
Err(CreationError::Zero)
} else{
Ok(PositiveNonzeroInteger(value as u64))
}

}
}

Expand Down
4 changes: 1 addition & 3 deletions exercises/13_error_handling/errors5.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,12 @@
// Execute `rustlings hint errors5` or use the `hint` watch subcommand for a
// hint.

// I AM NOT DONE

use std::error;
use std::fmt;
use std::num::ParseIntError;

// TODO: update the return type of `main()` to make this compile.
fn main() -> Result<(), Box<dyn ???>> {
fn main() -> Result<(), Box<dyn error::Error >> {
let pretend_user_input = "42";
let x: i64 = pretend_user_input.parse()?;
println!("output={:?}", PositiveNonzeroInteger::new(x)?);
Expand Down
12 changes: 6 additions & 6 deletions exercises/13_error_handling/errors6.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
// Execute `rustlings hint errors6` or use the `hint` watch subcommand for a
// hint.

// I AM NOT DONE

use std::num::ParseIntError;

// This is a custom error type that we will be using in `parse_pos_nonzero()`.
Expand All @@ -23,16 +21,18 @@ enum ParsePosNonzeroError {
impl ParsePosNonzeroError {
fn from_creation(err: CreationError) -> ParsePosNonzeroError {
ParsePosNonzeroError::Creation(err)
}
}
// TODO: add another error conversion function here.
// fn from_parseint...
fn from_parseint(err: ParseIntError) -> ParsePosNonzeroError {
ParsePosNonzeroError::ParseInt((err))
}
}

fn parse_pos_nonzero(s: &str) -> Result<PositiveNonzeroInteger, ParsePosNonzeroError> {
// TODO: change this to return an appropriate error instead of panicking
// when `parse()` returns an error.
let x: i64 = s.parse().unwrap();
PositiveNonzeroInteger::new(x).map_err(ParsePosNonzeroError::from_creation)
let x: i64 = s.parse().map_err(ParsePosNonzeroError::from_parseint)?;
PositiveNonzeroInteger::new(x).map_err((ParsePosNonzeroError::from_creation))
}

// Don't change anything below this line.
Expand Down

0 comments on commit fd57c7a

Please sign in to comment.