-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Integration with OCI Object Storage #100
feature: Integration with OCI Object Storage #100
Conversation
task: 8697bjvqr
215c54e
to
2c6711c
Compare
public ResponseEntity<PostDto> createPost(@RequestParam String content, @AuthenticationPrincipal UserDetails userDetails) { | ||
PostDto postDto = postService.createPost(userDetails.getUsername(), content); | ||
@PostMapping(consumes = MediaType.MULTIPART_FORM_DATA_VALUE) | ||
public ResponseEntity<PostDto> createPost(@RequestPart("content") String content, @RequestPart(value = "pictures", required = false) List<MultipartFile> pictures, @AuthenticationPrincipal UserDetails userDetails) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we allow to users to make a post without a content? And put pictures only? If yes then I guess you should put required = false for content but it can be corrected on the next PR
@@ -39,6 +39,6 @@ void testFindBasicUserInfoByLogin() { | |||
assertNotNull(result.get().getId()); | |||
assertNotNull(result.get().getName()); | |||
assertNotNull(result.get().getSurname()); | |||
assertNotNull(result.get().getProfilePicture()); | |||
// assertNotNull(result.get().getProfilePicture()); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be removed?
Quality Gate passedIssues Measures |
task: 8697bjvqr
First part of the task which purpose was to integrate with Oracle Cloud Infrastucture Object Storage
TODO:
as the time is of essence, i'll firstly deliver Profiles module, and then return to these tasks listed above