Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Integration with OCI Object Storage #100

Conversation

KinTrae
Copy link
Collaborator

@KinTrae KinTrae commented Jan 8, 2025

task: 8697bjvqr

First part of the task which purpose was to integrate with Oracle Cloud Infrastucture Object Storage
image
image

TODO:

  • deletion of the post should also delete pictures from database and oci object storage
  • modification of the post

as the time is of essence, i'll firstly deliver Profiles module, and then return to these tasks listed above

@JimTheCat
Copy link
Owner

@KinTrae KinTrae force-pushed the CU-8697bjvqr_EPIC---API-v5---integration-with-OCI-Object-Storage_Kinga-Traczyk branch from 215c54e to 2c6711c Compare January 8, 2025 21:03
public ResponseEntity<PostDto> createPost(@RequestParam String content, @AuthenticationPrincipal UserDetails userDetails) {
PostDto postDto = postService.createPost(userDetails.getUsername(), content);
@PostMapping(consumes = MediaType.MULTIPART_FORM_DATA_VALUE)
public ResponseEntity<PostDto> createPost(@RequestPart("content") String content, @RequestPart(value = "pictures", required = false) List<MultipartFile> pictures, @AuthenticationPrincipal UserDetails userDetails) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we allow to users to make a post without a content? And put pictures only? If yes then I guess you should put required = false for content but it can be corrected on the next PR

@@ -39,6 +39,6 @@ void testFindBasicUserInfoByLogin() {
assertNotNull(result.get().getId());
assertNotNull(result.get().getName());
assertNotNull(result.get().getSurname());
assertNotNull(result.get().getProfilePicture());
// assertNotNull(result.get().getProfilePicture());
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed?

frontend/src/Features/CreatePost/CreatePost.tsx Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 9, 2025

@KinTrae KinTrae requested a review from JimTheCat January 9, 2025 18:08
@KinTrae KinTrae merged commit 3187861 into dev Jan 9, 2025
9 checks passed
@KinTrae KinTrae deleted the CU-8697bjvqr_EPIC---API-v5---integration-with-OCI-Object-Storage_Kinga-Traczyk branch January 9, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants