Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): add Kotlin Gradle Plugins link #4580

Merged
merged 2 commits into from
Nov 28, 2024
Merged

feat(docs): add Kotlin Gradle Plugins link #4580

merged 2 commits into from
Nov 28, 2024

Conversation

zoobestik
Copy link
Collaborator

No description provided.

@zoobestik zoobestik marked this pull request as ready for review November 27, 2024 22:24
@zoobestik zoobestik requested a review from a team as a code owner November 27, 2024 22:24
@koshachy koshachy self-assigned this Nov 28, 2024
docs/kr.tree Outdated
@@ -310,7 +310,8 @@
<toc-element toc-title="API reference">
<toc-element toc-title="Standard library (stdlib)" href="https://kotlinlang.org/api/latest/jvm/stdlib/"/>
<toc-element toc-title="Test library (kotlin.test)" href="https://kotlinlang.org/api/latest/kotlin.test/"/>
<toc-element toc-title="Coroutines (kotlinx.coroutines)" href="https://kotlinlang.org/api/kotlinx.coroutines/kotlinx-coroutines-core/"/>
<toc-element toc-title="Kotlin Gradle Plugins (kotlin-gradle-plugin)" href="https://kotlinlang.org/api/kotlin-gradle-plugin/"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question:
From my perspective, it doesn't seem clear that there are actually two APIs:

  • Kotlin Gradle plugin
  • Compose compiler Gradle plugin

What do you think if we use both of them in a tree?
Like:

<toc-element toc-title="Kotlin Gradle plugin" href="https://kotlinlang.org/api/kotlin-gradle-plugin/kotlin-gradle-plugin-api/"/>
<toc-element toc-title="Compose compiler Gradle plugin" href="https://kotlinlang.org/api/kotlin-gradle-plugin/compose-compiler-gradle-plugin/"/>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And about positioning: I'd like to put it as the last items in a list.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tapchicoma what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, we most probably add in the future reference for other Gradle plugins for our compiler plugins (e.g. allopen). So I think I prefer current approach.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's try your approach and revisit this question later.
@zoobestik can you put the item lower and rename it to "plugins" not "Plugins"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆙

@zoobestik zoobestik force-pushed the kgp-link branch 2 times, most recently from 35ce157 to bfc5264 Compare November 28, 2024 14:09
@zoobestik zoobestik requested a review from koshachy November 28, 2024 14:25
Copy link
Collaborator

@koshachy koshachy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion.

@zoobestik zoobestik merged commit f15458c into master Nov 28, 2024
4 checks passed
@zoobestik zoobestik deleted the kgp-link branch November 28, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants