Skip to content

Localization: strings, regional formats, tests #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

ElviraMustafina
Copy link
Collaborator

No description provided.

@ElviraMustafina ElviraMustafina requested a review from a team as a code owner May 19, 2025 15:05
Copy link
Collaborator

@zamulla zamulla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The intro to strings needs some attention, but nothing critical 👍

@ElviraMustafina ElviraMustafina requested a review from igordmn May 21, 2025 05:03
@igordmn igordmn removed their request for review May 21, 2025 12:11
@terrakok
Copy link
Member

I'm not sure, but maybe it is worth to mention that web targets don't have fonts to render arabic, chinese and other locales. So, users are supposed to preload custom fonts for that.

Example: terrakok/WikWok#6
Fix: terrakok/WikWok@11222e6

@ElviraMustafina
Copy link
Collaborator Author

@terrakok We already have Preload resources using the Compose Multiplatform preload API with a code sample for a fallback font, so I added links to this section from:

  • RTL languages | Fonts for web targets: short example + link
  • Using multiplatform resources in your app | Resource usage | Fonts: link

@ElviraMustafina ElviraMustafina merged commit cad4df3 into master May 28, 2025
@ElviraMustafina ElviraMustafina deleted the CMP-7448-localization branch May 28, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants