Load markdown images with Coil3 #327
Conversation
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Outdated
Show resolved
Hide resolved
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Outdated
Show resolved
Hide resolved
obask
force-pushed
the
feature-image-loading
branch
from
98c42bc to
806f009
Compare
obask
force-pushed
the
feature-image-loading
branch
3 times, most recently
from
57f2c0a to
38797b6
Compare
obask
force-pushed
the
feature-image-loading
branch
from
38797b6 to
78a3bc9
Compare
| /** | ||
| * This method sets up an image loader with a memory cache but disables the disk cache. Disabling the disk cache is | ||
| * necessary because Coil crashes when attempting to use the file system cache with IDEA platform. | ||
| * | ||
| * Otherwise Coil3 will throw java.lang.NoSuchMethodError: kotlinx.coroutines.CoroutineDispatcher.limitedParallelism | ||
| */ |
There was a problem hiding this comment.
Have you filed a Coil bug for this? Or is there a workaround, like moving the init to the bridge and standalone modules, handling things differently in each case? For what you write, disk caching should work fine in standalone as-is, and may require a different approach for the bridge, where we provide a custom implementation that works in IJP.
There was a problem hiding this comment.
My thought is that this issue is specific to our way of loading dependencies in ide-plugin(or kotlin versions). I think we can add a todo here to delete this invocation once we move Jewel to the platform, since this will likely streamline all dependencies.
This workaround is not needed for standalone mode.
There was a problem hiding this comment.
This workaround is not needed for standalone mode.
So it should only be done in the bridge version, and indeed we need an issue to track checking this again when we move to the IJP
There was a problem hiding this comment.
Markdown is invoked directly from the example code. Do you know how to add it to the bridge only?
Additionally, if we change IDE vs Standalone behaviour, it would be much more difficult to figure out if something is wrong in one but works fine in another.
markdown/core/src/main/kotlin/org/jetbrains/jewel/markdown/processing/MarkdownProcessor.kt
Outdated
Show resolved
Hide resolved
.../core/src/main/kotlin/org/jetbrains/jewel/markdown/rendering/DefaultMarkdownBlockRenderer.kt
Outdated
Show resolved
Hide resolved
.../core/src/main/kotlin/org/jetbrains/jewel/markdown/rendering/DefaultMarkdownBlockRenderer.kt
Outdated
Show resolved
Hide resolved
.../core/src/main/kotlin/org/jetbrains/jewel/markdown/rendering/DefaultMarkdownBlockRenderer.kt
Outdated
Show resolved
Hide resolved
| model = | ||
| ImageRequest.Builder(LocalPlatformContext.current).data(image.source).size(Size.ORIGINAL).build(), | ||
| contentDescription = image.title, | ||
| // TODO: figure out what to use instead of *.sp |
There was a problem hiding this comment.
InlineTextContent only accepts size in as a TextUnit which is either em or sp. I'll change logic to use more advanced conversion.
I polished this logic a bit and added a comment, but I haven't figured out how to make Coil scale up images to the size of placeholder.
obask
force-pushed
the
feature-image-loading
branch
from
78a3bc9 to
f076393
Compare
| ) | ||
| } | ||
| ) { | ||
| AsyncImage( |
There was a problem hiding this comment.
BTW you need to make sure Ktor is initialised correctly (e.g., in the IDE it needs to respect the IDE proxy settings).
As a starting point, you can do something like this: https://gist.github.com/rock3r/6f633cb0e5b73625cc6ec0570896ff85
Of course this needs more work than just copy pasting it, but it should point you in the right direction
There was a problem hiding this comment.
as we discussed offline, it would be easier to do after the intellij-community move
There was a problem hiding this comment.
Be warned you'll have to recreate the branch and PR on the IJ repo. You'll also need to manage both Gradle and JPS builds in parallel
|
@obask for inline images, you can probably take inspiration from https://github.com/halilozercan/compose-richtext/blob/main/richtext-ui/src/commonMain/kotlin/com/halilibo/richtext/ui/string/InlineContent.kt |
It supports every image as inline
obask
force-pushed
the
feature-image-loading
branch
from
f076393 to
46f29ca
Compare
I think it does the same |
|
And I fixed images scaling, BTW. It shows them the same way as other markdown editors. |
No description provided.