Fix Del and BS not working in Select mode #1079
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wanting to add `ReturnTo.SELECT` would be very tricky, as we would have to recreate the mode, but have no details about the selection type.
citizenmatt
force-pushed
the
bugfix/select-delete
branch
from
5e9c45e to
5b1b4ae
Compare
From Select mode, enters Visual for a single command
Fixes VIM-3618
Fixes VIM-3042
citizenmatt
force-pushed
the
bugfix/select-delete
branch
from
5b1b4ae to
5275057
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when hitting
<Del>or<BS>to delete selected text in Select mode would fail to delete anything. The implementation would try to invoke native actions to delete but had two problems. Firstly, it would fail to filter out the IdeaVim action bound to the keystroke and would recurse (but fail to invoke anything). Secondly, it would also try to invoke instances ofEmptyAction, which are placeholder actions that are used to reserve a shortcut. Code will use look for these actions by ID to look up the shortcut to use when dynamically registering the real action locally in aComponent. We gather these locally registered actions, so it's safe to ignore the empty action.It also correctly transitions from Select mode to Normal or Insert/Replace, depending on context. If Select mode was started from Normal (via
ghorv<C-G>), then it will return to Normal. If started in Insert/Replace mode via shifted keys, then it will return to Insert/Replace. As part of this, it correctly positions the caret, especially when deleting the last text character in a line.Fixes VIM-3618 and VIM-3042.
This PR depends on #1078, specifically to handle the correct mode transitions. As such, it lists a load of unnecessary commits from that branch. Once #1078 is merged, I'll rebase, force push and mark this PR as no longer draft. Here is the list of commits in this PR: 272bea0...5275057