-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up user-facing strings to facilitate translation #158
Open
JesseTG
wants to merge
16
commits into
dev
Choose a base branch
from
jtg/clean-up-strings
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lean-up-strings # Conflicts: # src/libretro/strings/en_us.hpp
# Conflicts: # src/libretro/core/core.cpp
There are a few things I need to do:
There are other things I need to do for actual Crowdin integration, but those can come later. |
- Oughta simplify things for translators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes in service of a simpler translation process:
#ifdef
s for some core options complicates translation #151Log messages are not modified; the people who will read them (mostly me) already know English well.
@DisasterMo is the one implementing the scripts needed to manage translation via Crowdin. With that in mind, I have a few questions:
fmt
arguments that I may need to clarify.retro_core_options_v2_intl
, but I'd like to hear your thoughts about looking up the other strings at runtime.