Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up user-facing strings to facilitate translation #158

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from

Conversation

JesseTG
Copy link
Owner

@JesseTG JesseTG commented Jan 30, 2024

This PR makes the following changes in service of a simpler translation process:

Log messages are not modified; the people who will read them (mostly me) already know English well.

@DisasterMo is the one implementing the scripts needed to manage translation via Crowdin. With that in mind, I have a few questions:

  • Is there a way to add translator's notes (even if it's just in the form of a comment)? I don't want to assume that the translators are intimately familiar with melonDS. Plus, there are some fmt arguments that I may need to clarify.
  • How do you envision that translated strings besides those defined in core options will be used? I know about retro_core_options_v2_intl, but I'd like to hear your thoughts about looking up the other strings at runtime.
  • Once the translation workflow is set up, what should I not change?

@JesseTG
Copy link
Owner Author

JesseTG commented Feb 13, 2024

There are a few things I need to do:

  • Add parameters to each (user-facing) format string
  • Write translator's notes (just as comments for now)

There are other things I need to do for actual Crowdin integration, but those can come later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant