💩 NICE-60 short-term preload until canary fix [b] #1714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Is this any better? Ideally would only preload the size
JeromeFitz
added
the
🚧️ WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this any better? Ideally would only preload the size
Not a major sample size given the amount of PRs that have been done with these perf updates. Not sure if this is going to be consistent, or just better:
FCP: -0.2sLCP: -0.7sTBT: -10msSI: -0.1sThis is kind of splitting hairs a bit also. Just curious. RES is still
100, just know it can be better and at larger scale.EDIT: Then it went way worse, heh. Something weird with the
e2einstal too. Going to close this PR as this looks to be handled soon in a canary release fornext💯