Skip to content

Commit

Permalink
🩹 jeromefitz/[email protected] (#2098)
Browse files Browse the repository at this point in the history
After changes to remove unnecessary ported functions verify things still work.

Fixed an issue with `lodash` being made into a relative import.

I think having its own `cloneObject` makes it smaller as relying on `lodash` seems like a lot.

Could perhaps do `lodash.clonedeep` _only_ but not sure I am already spending way too much time on this haha
  • Loading branch information
JeromeFitz committed Dec 28, 2023
1 parent e9bfd0c commit dd0523d
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18.13.0
18.17.0
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"private": true,
"packageManager": "^[email protected]",
"engines": {
"node": ">=18"
"node": ">=18.17.0"
},
"scripts": {
"clean:install": "turbo run clean && ./scripts/clean.sh",
Expand Down
6 changes: 4 additions & 2 deletions packages/next-notion/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"semantic-release": "echo semantic-release"
},
"peerDependencies": {
"@jeromefitz/date-fns-tz": "^3.0.0-canary.3",
"@jeromefitz/date-fns-tz": "^3.0.0-canary.7",
"@jeromefitz/utils": "^2.2.2",
"@notionhq/client": "^2.2.6",
"date-fns": "^3.0.6",
Expand All @@ -39,11 +39,13 @@
"node-emoji": "2.1.3"
},
"devDependencies": {
"@jeromefitz/date-fns-tz": "3.0.0-canary.3",
"@jeromefitz/date-fns-tz": "3.0.0-canary.7",
"@jeromefitz/ds": "workspace:*",
"@jeromefitz/utils": "2.2.2",
"@notionhq/client": "2.2.14",
"@types/lodash": "4.14.202",
"date-fns": "3.0.6",
"lodash": "4.17.21",
"next": "14.0.4",
"react": "18.2.0",
"react-dom": "18.2.0",
Expand Down
28 changes: 21 additions & 7 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion sites/jeromefitzgerald.com/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
},
"dependencies": {
"@heroicons/react": "2.1.1",
"@jeromefitz/date-fns-tz": "3.0.0-canary.3",
"@jeromefitz/date-fns-tz": "3.0.0-canary.7",
"@jeromefitz/design-system": "4.2.3",
"@jeromefitz/notion": "4.0.7",
"@jeromefitz/spotify": "3.0.4",
Expand Down Expand Up @@ -112,6 +112,7 @@
"immer": "10.0.3",
"ioredis": "5.3.2",
"isomorphic-unfetch": "4.0.2",
"lodash": "4.17.21",
"ms": "3.0.0-canary.1",
"next": "14.0.4",
"next-themes": "0.2.1",
Expand Down Expand Up @@ -148,6 +149,7 @@
"@jeromefitz/storybook-config": "workspace:*",
"@jeromefitz/tailwind-config": "workspace:*",
"@jeromefitz/tsconfig": "1.1.3",
"@types/lodash": "4.14.202",
"@types/ms": "0.7.34",
"@types/pluralize": "0.0.33",
"@types/ramda": "0.29.9",
Expand Down

0 comments on commit dd0523d

Please sign in to comment.