-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
✨ NICE-99 simplified layout [b] (#2528)
Well, what started as a "simplified layout" turned into a complete rewrite and of course since I did not really set out with a goal things are all over the place. 🤣 So started taking some control and breaking down some smaller tasks. It is at the point where it is "shippable" but just means more tweaks down the line because there are still a lot of pages not migrated / updated for either layout. ## Commits 🚧 NICE-99 move to zustand for temp mocks 🚧 NICE-99 more prep to move to a layout 🚧 NICE-99 more cta stuff 🚧 NICE-99 why did i think this would not take 4eva 🚧 NICE-99 body m-0 hack for dropdown 🚧 NICE-99 pixel perfect means... something i guess 🚧 NICE-99 px px px px px px 3vrywhr3 🚧 NICE-99 hidden good for aria|a11y 🚧 NICE-99 add icons, expand left col 🚚 NICE-99 start moving components for routing 🚧 NICE-99 continue to migrate to new layout 🚧 NICE-99 seems like a hack, but passes lighthouse 🚧 NICE-99 as always scope to the creep 🚧 NICE-107 cta z-index fix 🚧 NICE-103 books|music => currently/r|l-to 🚚 NICE-116 (next) redirects for currently 🚧 NICE-99 file renames and Box usage 🚧 NICE-106 mobile padding below container main 🚧 NICE-112 styled OL|UL|LI 🚨 NICE-99 pass lint 😮💨 🚧 NICE-101 pass event data 🚧 NICE-106 really fix padding this time 🚧 NICE-118 fix px, mobile first 🚧 NICE-118 mobile first 🚧 NICE-119 listening|reading move into "new" format for now 🚧 NICE-99 what timing this is being fixed... 🚧 NICE-99 more tailwind tweaks (pick a lane!) 🚧 NICE-99 pause for radix-ui circ 🐛 (radix-ui) NICE-120 circular deps ⬆️ (deps) @radix-ui/[email protected] ⬆️ (deps) package upgrades... 📦️ (deps) clean up deps from peers 🚧 NICE-119 reduce currently complexity ⬆️ (deps) @jeromefitz/[email protected] ⬆️ (deps) [email protected] (from 0.32.6 ...) 💄 NICE-119 tighten things up 🚧 NICE-99 more cleanup... ⬇️ (deps) [email protected] (revert) 🚧 NICE-99 rework fonts a bit; sidebar border ⬆️ (deps) playwright, storybook, vercel/analytics... ⬆️ (deps) vercel/analytics|speed-insights 🚧 NICE-99 overcomplicated currently prep ⬆️ (deps) [email protected] ⬆️ [email protected] 🚧 NICE-99 uh ... why did spotify do this 🚧 NICE-99 layout tweaks, gradient/blur ⬆️ (deps) [email protected] 🚧 NICE-99 useSWRInfinitePages 🔥 jf/ds 🏷️ NICE-99 ugh tis port is awful 🚧 NICE-99 hide cmdk, add skip nav ➕ (deps) clean-up storybook and root eslint ⬆️ (deps) [email protected] 🔒️ (next) https localhost 💩 NICE-99 hack for mouseOver on dropdown 💩 NICE-99 yup revert that onMouse stuff 🚧 NICE-99 smoothscroll section legend ♻️ NICE-99 no client component, use scrollMarginTop ⬆️ (deps) ts-jest 🚧 NICE-99 section side scroller ⬆️ (deps) storybook, framer-motion, types/node ⬆️ (deps) types/node;framer-motion 🚧 NICE-99 guess i need to write ocntent now ⬆️ (deps) types/node, ramda ♿️ NICE-99 lhci updates
- Loading branch information
1 parent
306fb44
commit d36bb21
Showing
127 changed files
with
10,279 additions
and
7,424 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
import { Box } from '@radix-ui/themes/dist/esm/components/box.js' | ||
import { Link } from '@radix-ui/themes/dist/esm/components/link.js' | ||
import { forwardRef } from 'react' | ||
|
||
import { cx } from '../../utils/cx' | ||
|
||
const defaultId = 'skip-nav' | ||
|
||
interface SkipNavLinkProps { | ||
children?: React.ReactNode | ||
contentId?: string | ||
} | ||
interface SkipNavContentProps { | ||
children?: React.ReactNode | ||
id?: string | ||
} | ||
|
||
const SkipNavLink = forwardRef(function SkipNavLink( | ||
{ children = 'Skip to content', contentId, ...props }: SkipNavLinkProps, | ||
forwardedRef, | ||
) { | ||
const id = contentId || defaultId | ||
return ( | ||
<Link | ||
{...props} | ||
className={cx( | ||
'rounded-3 bg-accent-1 absolute right-[100%] top-2 z-50 block p-4', | ||
'focus:left-2.5 focus:right-auto', | ||
)} | ||
data-skip-nav-content="" | ||
href={`#${id}`} | ||
// eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
// @ts-ignore | ||
ref={forwardedRef} | ||
tabIndex={0} | ||
> | ||
{children} | ||
</Link> | ||
) | ||
}) | ||
SkipNavLink.displayName = 'SkipNavLink' | ||
|
||
const SkipNavContent = forwardRef(function SkipNavContent( | ||
{ id: idProp, ...props }: SkipNavContentProps, | ||
forwardedRef, | ||
) { | ||
const id = idProp || defaultId | ||
return ( | ||
// eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
// @ts-ignore | ||
<Box {...props} asChild id={id} ref={forwardedRef} /> | ||
) | ||
}) | ||
SkipNavContent.displayName = 'SkipNavContent' | ||
|
||
export { SkipNavContent, SkipNavLink } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export { SkipNavContent, SkipNavLink } from './SkipNav' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
export { Anchor } from './Anchor/index' | ||
export { Callout } from './Callout/index' | ||
export { Icon } from './Icon/index' | ||
export { SkipNavContent, SkipNavLink } from './SkipNav/index' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
export { useSWRInfinitePages } from './useSWRInfinitePages' | ||
export { useThemeToggle } from './useThemeToggle' | ||
export { useThrottle } from './useThrottle' |
Oops, something went wrong.