🚑 hrm, prefer if this was hotfix not quickfix

Oh yea ... this fixes the type error
JeromeFitz · Mar 28, 2021 · 3bd3410 · 3bd3410
1 parent 23efb5a
commit 3bd3410
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/components/Dynamic/column-container.tsx b/components/Dynamic/column-container.tsx
@@ -3,7 +3,7 @@ import React from 'react'
 
 const columnContainer = ({ id, content }) => {
   return (
-    <div className="columnContainer" key={`${id}--cc`}>
+    <div className="columnContainer">
       {content.map((data, dataIndex) => {
         const children = _merge(
           { ...data.props.children },

diff --git a/lib/notion/helpers/renderNotionContent.tsx b/lib/notion/helpers/renderNotionContent.tsx
@@ -73,7 +73,7 @@ const renderNotionContent = (data) => {
 
         // const renderHeading = (Type: string | React.ComponentType) => {
         //   toRender.push(
-        //     <Heading key={id} key={id}>
+        //     <Heading key={id}>
         //       <Type key={id}>{textBlock({parentKey: id, pRenderTag: true, text: properties.title)}</Type>
         //     </Heading>
         //   )
@@ -83,6 +83,7 @@ const renderNotionContent = (data) => {
           // console.warn(`> renderColumn`)
           // console.dir(data)
           const columnData = renderNotionContent({ content: data })
+          // @note(jsx) no key needed here
           toRenderColumn.push(<components.Column>{columnData}</components.Column>)
         }
 
@@ -118,7 +119,7 @@ const renderNotionContent = (data) => {
           })
 
           toRender.push(
-            <components.ColumnContainer content={toRenderColumn} key={id} key={id} />
+            <components.ColumnContainer content={toRenderColumn} id={id} key={id} />
           )
           toRenderColumn = []
           columnMap = {}