Skip to content
This repository has been archived by the owner on Jun 3, 2022. It is now read-only.

/anchors endpoint #389

Closed
wants to merge 18 commits into from
Closed

/anchors endpoint #389

wants to merge 18 commits into from

Conversation

siradji
Copy link
Contributor

@siradji siradji commented Sep 15, 2021

What kind of PR is this?:

/kind feature

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes BirthdayResearch/jellyfishsdk#1488

Additional comments?:

@codeclimate
Copy link

codeclimate bot commented Sep 15, 2021

Code Climate has analyzed commit 825b426 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #389 (8b06b1a) into main (a6db7fb) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 8b06b1a differs from pull request most recent head 825b426. Consider uploading reports for the commit 825b426 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     JellyfishSDK/whale#389      +/-   ##
==========================================
+ Coverage   93.88%   93.93%   +0.04%     
==========================================
  Files         104      106       +2     
  Lines        2257     2275      +18     
  Branches      250      250              
==========================================
+ Hits         2119     2137      +18     
  Misses        138      138              
Impacted Files Coverage Δ
packages/whale-api-client/src/api/anchors.ts 100.00% <100.00%> (ø)
packages/whale-api-client/src/index.ts 100.00% <100.00%> (ø)
packages/whale-api-client/src/whale.api.client.ts 78.04% <100.00%> (+0.54%) ⬆️
src/module.api/_module.ts 100.00% <100.00%> (ø)
src/module.api/anchors.controller.ts 100.00% <100.00%> (ø)
src/module.indexer/model/block.ts 100.00% <0.00%> (ø)
src/module.indexer/model/transaction.ts 100.00% <0.00%> (ø)
src/module.api/transaction.controller.ts 91.30% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6db7fb...825b426. Read the comment docs.

@fuxingloh fuxingloh removed their request for review September 16, 2021 04:07
@siradji siradji changed the title Added Listanchors endpoint /anchors endpoint Sep 16, 2021
@siradji
Copy link
Contributor Author

siradji commented Sep 16, 2021

@fuxingloh , I found out you want to add listanchors to masternode controller alone. I have already created a controller for anchors. Should i keep it or just go as planned?

@siradji
Copy link
Contributor Author

siradji commented Sep 16, 2021

@fuxingloh could you give me some pointers on why my test is failing?

Dockerfile Outdated Show resolved Hide resolved
src/module.api/anchors.controller.ts Outdated Show resolved Hide resolved
src/module.api/anchors.controller.e2e.ts Outdated Show resolved Hide resolved
@siradji siradji marked this pull request as ready for review September 23, 2021 04:46
src/module.api/anchors.controller.ts Outdated Show resolved Hide resolved
src/module.api/anchors.controller.ts Outdated Show resolved Hide resolved
packages/whale-api-client/src/api/anchors.ts Outdated Show resolved Hide resolved
@fuxingloh fuxingloh marked this pull request as draft September 26, 2021 13:51
@siradji
Copy link
Contributor Author

siradji commented Sep 30, 2021

@fuxingloh, pagination has been implemented via minBtcHeight and maxBtcHeight. I think it is not the most ideal way and we need some better in the future.

@fuxingloh fuxingloh added the priority/important-soon Will be important soon label Nov 4, 2021
@fuxingloh
Copy link
Contributor

Close in favor of #719

@fuxingloh fuxingloh closed this Jan 23, 2022
@github-actions github-actions bot removed the kind/feature New feature request label May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/anchors endpoint
5 participants