Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack of tests and fixes #65

Merged
merged 16 commits into from
Feb 9, 2024
Merged

Pack of tests and fixes #65

merged 16 commits into from
Feb 9, 2024

Conversation

KlausC
Copy link
Collaborator

@KlausC KlausC commented Nov 1, 2023

Add test cases for the ArbComplextype.

A few bug and simplifications were made to the source code,
as revealed by test failures, and to simplify test coverage.

Some test cases are declared 'broken', have to be fixed.

The more test cases are developed, the more glitches in the software are detected, which are removed.

For the releases before nightly, on windows, CI cannot load the required packages. Those runs were removed from the CI matrix.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 43 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/ArbNumerics.jl 100.00% <ø> (ø)
src/ArbTypes.jl 100.00% <100.00%> (ø)
src/float/prearith.jl 100.00% <100.00%> (+60.81%) ⬆️
src/libarb/ArbComplex.jl 100.00% <100.00%> (+79.47%) ⬆️
src/libarb/ArbFloat.jl 100.00% <100.00%> (+85.21%) ⬆️
src/libarb/ArbReal.jl 100.00% <100.00%> (+75.00%) ⬆️
src/support/complex.jl 100.00% <100.00%> (+82.69%) ⬆️
src/support/minprec.jl 100.00% <100.00%> (+100.00%) ⬆️
src/values/compare.jl 64.10% <100.00%> (+3.93%) ⬆️
src/values/constructors.jl 100.00% <100.00%> (+86.48%) ⬆️
... and 10 more

... and 8 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@KlausC KlausC marked this pull request as draft November 1, 2023 22:19
@KlausC
Copy link
Collaborator Author

KlausC commented Nov 1, 2023

Will further increase test coverage and remove redundancies.

@KlausC KlausC changed the title Pack of tests and trivial fixes Pack of tests and fixes Nov 3, 2023
@P3109
Copy link

P3109 commented Nov 22, 2023

if/when you want this merged -- change it from draft status

@KlausC KlausC marked this pull request as ready for review November 23, 2023 12:54
@KlausC
Copy link
Collaborator Author

KlausC commented Nov 23, 2023

This state of development is now more stable then ever, also if it is not perfect yet. Can be reviewed/merged.

@JeffreySarnoff JeffreySarnoff merged commit 261e5fe into main Feb 9, 2024
6 of 8 checks passed
@JeffreySarnoff
Copy link
Owner

I thought I had merged this long before -- thank you!

@KlausC KlausC deleted the krc/testcomplex branch February 9, 2024 13:51
@JeffreySarnoff
Copy link
Owner

Hi Klaus,
We have a report of a glitch that followed this update ..
Please take a look and let me know if you see a fix.
#68 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants