Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] Exam #238

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Conversation

Rajan-SCS
Copy link
Contributor

No description provided.

@Rajan-SCS Rajan-SCS force-pushed the 16_mig_exam branch 2 times, most recently from b57f540 to 3fdf127 Compare February 2, 2023 13:00
"re-evaluation",
"re-evaluation_confirm",
]:
if rec.obtain_marks >= 0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use only one if condition, please combine 726 and 727 line

if rec.obtain_marks >= grade_id.from_mark and b_id:
rec.grade_line_id = grade_id
else:
if rec.marks_reeval and rec.obtain_marks >= 0.0:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing why using 2 if conditions? @Rajan-SCS

@AnuKPatel AnuKPatel merged commit bf695d1 into JayVora-SerpentCS:16.0 Feb 3, 2023
@RiteshSerpentCS RiteshSerpentCS mentioned this pull request Mar 1, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants