Skip to content

Commit

Permalink
Fix part of oppia#19217: Add feature flag for lesson player redesign (o…
Browse files Browse the repository at this point in the history
…ppia#19524)

Add feature flag for lesson player redesign
  • Loading branch information
Vir-8 authored Jan 19, 2024
1 parent 476e544 commit 6398a3e
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 3 deletions.
1 change: 1 addition & 0 deletions core/domain/platform_parameter_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,4 @@ class ParamNames(enum.Enum):
'unpublish_exploration_email_html_body')
CD_ADMIN_DASHBOARD_NEW_UI = 'cd_admin_dashboard_new_ui'
RECORD_PLAYTHROUGH_PROBABILITY = 'record_playthrough_probability'
NEW_LESSON_PLAYER = 'new_lesson_player'
3 changes: 2 additions & 1 deletion core/domain/platform_parameter_list_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ class ExistingPlatformParameterValidityTests(test_utils.GenericTestBase):
'show_translation_size',
'signup_email_body_content',
'signup_email_subject_content',
'unpublish_exploration_email_html_body']
'unpublish_exploration_email_html_body',
'new_lesson_player']

def test_all_defined_parameters_are_valid(self) -> None:
all_names = (
Expand Down
5 changes: 5 additions & 0 deletions core/domain/platform_parameter_registry.py
Original file line number Diff line number Diff line change
Expand Up @@ -458,6 +458,11 @@ def _to_platform_parameter_model(
'Enable learner groups feature',
platform_parameter_domain.FeatureStages.PROD)

Registry.create_feature_flag(
ParamNames.NEW_LESSON_PLAYER,
'This flag is to enable the exploration player redesign.',
platform_parameter_domain.FeatureStages.DEV)

Registry.create_platform_parameter(
ParamNames.PROMO_BAR_ENABLED,
'Whether the promo bar should be enabled for all users',
Expand Down
3 changes: 2 additions & 1 deletion core/platform_feature_list.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@
DEV_FEATURES_LIST = [
params.ParamNames.SHOW_FEEDBACK_UPDATES_IN_PROFILE_PIC_DROPDOWN,
params.ParamNames.SHOW_REDESIGNED_LEARNER_DASHBOARD,
params.ParamNames.SHOW_TRANSLATION_SIZE
params.ParamNames.SHOW_TRANSLATION_SIZE,
params.ParamNames.NEW_LESSON_PLAYER
]

# Names of features in test stage, the corresponding feature flag instances must
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ export enum FeatureNames {
ShowRedesignedLearnerDashboard = 'show_redesigned_learner_dashboard',
IsImprovementsTabEnabled = 'is_improvements_tab_enabled',
LearnerGroupsAreEnabled = 'learner_groups_are_enabled',
CdAdminDashboardNewUi = 'cd_admin_dashboard_new_ui'
CdAdminDashboardNewUi = 'cd_admin_dashboard_new_ui',
NewLessonPlayer = 'new_lesson_player'
}

export interface FeatureStatusSummaryBackendDict {
Expand Down

0 comments on commit 6398a3e

Please sign in to comment.