Skip to content

Commit

Permalink
Disabling neon for libvpx in case llvm and armv7
Browse files Browse the repository at this point in the history
  • Loading branch information
Javernaut committed Oct 21, 2021
1 parent fe99b1c commit bacbe4a
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 1 deletion.
5 changes: 5 additions & 0 deletions scripts/export-build-variables.sh
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,11 @@ export FAM_CC=${TOOLCHAIN_PATH}/bin/${TARGET}-clang
export FAM_CXX=${FAM_CC}++
export FAM_LD=${FAM_CC}

if [[ $DESIRED_BINUTILS == "llvm" ]]; then
# The llvm-as doesn't work in place of gnu as, so just using clang here
export FAM_AS=${FAM_CC}
fi

# TODO consider abondaning this strategy of defining the name of the clang wrapper
# in favour of just passing -mstackrealign and -fno-addrsig depending on
# ANDROID_ABI, ANDROID_PLATFORM and NDK's version
Expand Down
3 changes: 3 additions & 0 deletions scripts/libvpx/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ case $ANDROID_ABI in
;;
armeabi-v7a)
EXTRA_BUILD_FLAGS="--target=armv7-android-gcc --enable-thumb"
if [[ $DESIRED_BINUTILS == "llvm" ]]; then
EXTRA_BUILD_FLAGS+=" --disable-neon"
fi
;;
arm64-v8a)
EXTRA_BUILD_FLAGS="--target=arm64-android-gcc --enable-thumb"
Expand Down
2 changes: 1 addition & 1 deletion scripts/libvpx/download.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

source ${SCRIPTS_DIR}/common-functions.sh

VPX_VERSION=v1.10.0
VPX_VERSION=v1.11.0

downloadTarArchive \
"libvpx" \
Expand Down

0 comments on commit bacbe4a

Please sign in to comment.