Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional set operations #25

Closed
wants to merge 1 commit into from

Conversation

michaelmior
Copy link
Contributor

@michaelmior michaelmior commented Aug 21, 2019

This provides a partial implementation for #18. Basically almost the same grammar is used but INTERSECT and EXCEPT are allowed as keywords in addition to UNION. Each of these parses into a new kind of top-level expression. This is roughly following what Postgres does since these are not all supported by MySQL.

@albin3
Copy link
Member

albin3 commented Aug 22, 2019

@michaelmior Thanks for this pr, but I don't want to merge this one.

In my opinion, It will be easier to maintain this repo just support mysql syntax follows official document. Source code can be readable too.

On the other hand, table join syntax can touch the aim of what INTERSECT and EXCEPT do.

@michaelmior
Copy link
Contributor Author

No problem, I understand although I don't really see this making things less readable. Of course queries can be rewritten, but this doesn't help when I need to parse the alternative syntax. That said, I can always maintain my own fork and I appreciate having this as a starting point :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants