Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the tab badge disappear if the value is "0" #290

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

drwasho
Copy link
Contributor

@drwasho drwasho commented Nov 3, 2017

As per the title.

gliechtenstein and others added 11 commits October 28, 2017 07:36
* Add Vision Service, replace PBJVision with native AVFoundation

* $vision action

* limit payload to type and content for now

* Remove PBJVision dependency
* Implement Switch Component

See Jasonette/Jasonette#1
And issue Jasonette#275

* exception handling for name/action + use boolean for isOn

* Fixed color:disabled
Suitable for inputting currency amounts.
As seen in https://stackoverflow.com/questions/46344159/whats-difference-between-nsphotolibraryaddusagedescription-and-nsphotolibraryus

I think it's a bug Apple needs to fix, since it should work even without that permission (NSPhotoLibraryDescription should be enough, which already exists on Info.plist). But still need to fix since Apple won't fix it.
@gliechtenstein
Copy link
Contributor

This should work with the existential operator https://selecttransform.github.io/site/transform.html#4-existential-operator - which was introduced with the recent transition to ST.

Try that and see if that works. I don't think it's a good idea to add this condition since there may be cases where you would want to display "0" as a badge value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants