refactor: replace try/catch blocks with assertThrows #4806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-boxuan
reviewed
Jul 6, 2025
janusgraph-backend-testutils/src/main/java/org/janusgraph/diskstorage/log/LogTest.java
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…sting Signed-off-by: Rian-Ismael <[email protected]>
Member
|
Hi @Rian-Ismael , please address the comment here and then request for another round of review |
Rian-Ismael
force-pushed
the
master
branch
4 times, most recently
from
6862a62 to
1a36b6b
Compare
Contributor
Author
Hi @li-boxuan, thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces manual try/catch blocks with assertThrows to improve readability and align with modern testing practices.
Using assertThrows clarifies the test intent, eliminates unnecessary control flow, and ensures that exception validation is concise and consistent.
This enhances test maintainability and makes failures easier to debug.
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master)?