-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle LaTeX files with non .tex
extension
#4466
Conversation
This variable lists all the file extensions that LW will consider as LaTeX files.
I’m good with the change, just one thing: it seems that changing the config cannot change the respective behavior on-the-fly, until a vscode reload. May be we move the new ext var to file.ts, and register an onConfigChange handler to change it lively? |
It is not completely clear to me because allowing to change the value on-the-fly will only work for adding more extensions. Files with extensions that were cached will not be removed from the caching mechanism. So I am a bit hesitating. |
That's mostly for consistency. iirc changes on all other configs are now reflected immediately without the need of reload. Further, I ignored the impact on caches when changing the config. It might be more complex than I thought. |
Fine. I completely agree with the consistency argument. I will make the appropriate changes. |
Thanks for the tests. |
This is required to enable the recipe mechanism
@James-Yu Everything seems fine to me now. What do you think? |
Related to #4457
This PR adds a new configuration variable to let the user specify file extensions to be treated as LaTeX files similarly to
.tex
files.@James-Yu What do you think of this very little intrusive approach?