Support code folding for DocTeX #4426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Please extend a new doctex folding class for the implementation. It would be fine if you need to make |
|
Thank you for your response. I have updated the structure of the new DocTeX folding class, and added a new folding pattern that matches from |
|
I think it is ready for another review. |
James-Yu
reviewed
Oct 14, 2024
Comment on lines
+117
to
+122
| } else if (match[9]) { | ||
| keyword = '%<' + match[9] + '>' | ||
| } else if (match[10]) { | ||
| keyword = '%<' + match[10] + '>' | ||
| } else if (match[11] || match[12]) { | ||
| keyword = '%\\iffalse meta-comment' |
src/language/folding.ts
Outdated
| @@ -2,10 +2,11 @@ import * as vscode from 'vscode' | |||
|
|
|||
| export class FoldingProvider implements vscode.FoldingRangeProvider { | |||
| private readonly sectionRegex: RegExp[] = [] | |||
| protected readonly envRegex = /\\(begin){(.*?)}|\\(begingroup)[%\s\\]|\\(end){(.*?)}|\\(endgroup)[%\s\\]|^%\s*#?([rR]egion)|^%\s*#?([eE]ndregion)|^%\s*<\*([|_()\-a-zA-Z0-9]+)>|^%\s*<\/([|_()\-a-zA-Z0-9]+)>|^%\s*\\iffalse\s*(meta-comment)|^%\s*\\(fi)/gm | |||
There was a problem hiding this comment.
Seems you add new matches to this regexp. Are they only for DocTeX?
| @@ -113,11 +128,12 @@ export class FoldingProvider implements vscode.FoldingRangeProvider { | |||
| } | |||
| const lastItem = opStack[opStack.length - 1] | |||
|
|
|||
| if ((match[4] || match[6] || match[8]) && lastItem && lastItem.keyword === item.keyword) { // match 'end' with its 'begin' | |||
| if ((match[4] || match[6] || match[8] || match[10] || match[12]) && lastItem && lastItem.keyword === item.keyword) { // match 'end' with its 'begin' | |||
|
The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the LaTeX-Workshop extension by adding support for VSCode code folding for DocTeX files. The new functionality includes:
% \section{abc}.%<*abc>to%</abc>, whereabccan be replaced with characters such as|, ',', &, !, -, _, (, ).% \iffalse meta-commentto% \fi.Showcase for the
l3docclass: