3783 writing end autocomplete with another #4424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #3783 .
After a careful check (and partially thanks to the new unit test system), I finally figured out the root cause to #3783 :
Originally, we consider all env suggestions to have the begin-end snippet, unless within the brace
{}. This makes\end{without the ending}to be considered the same as\begin{, and a full snippet is inserted.This PR changed the behavior by making the suggestions default to
AsName, and insert full snippet of begin-end only when there is one active selection, the nearest macro is \begin (instead of \end), and selection is not in{}.Corresponding unit tests are added.
Note that this PR does not, and cannot, avoid vscode un-indenting
\end. Anyways it's not a big issue.