-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live share integration #4308
base: master
Are you sure you want to change the base?
Live share integration #4308
Conversation
Awesome! Great contribution @quoc-ho . Let's wait for review. |
The following functionalities have been implemented on guests (on the host, everything is the same as before):
Here, * means doesn't work when the guest is on a Windows computer. This is because on Windows, Build command cannot be triggered from the guest yet (but it's not hard to implement). For now, the host can just turn on build on save. Notes on the implementation
|
I'm back. On it in the next week(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check carefully (next step will do so), yet it seems that currently synctex from guest to host then back to guest is adding a lot of lines to the code, which is making the code quite convoluted.
I would recommend removing all host-guest communications related to synctex. For guest, rely on its local optionally-installed synctex
and fallback to the bundled synctexjs
implementation. This will make the code much more maintainable.
Thanks for looking into this. I think the changes are quite minimal. The large changes in I'm traveling for quite a while so I will be available only for comments if you have questions but probably not actually writing code. |
I've done some refactoring to follow minimal intrusion. May you have a check if the new code is equivalent when available? Further, as there are some limited functionalities on Windows, it would be good to have sort of notices when related functions are invoked on win. |
Great! I'll go over the refactor by Tuesday. |
commit ff2ca23 Author: James Yu <[email protected]> Date: Sun Aug 11 01:38:40 2024 +0800 Fix James-Yu#4334 PDF viewer position retained across vscode reloads commit be6da68 Author: Jerome Lelong <[email protected]> Date: Fri Aug 9 18:24:34 2024 +0200 Add highlighting to the extension logs (James-Yu#4331) * Fix typo in log * Highlight extension's logs * Do not highlight the finale full stop commit 693d709 Author: James Yu <[email protected]> Date: Sat Aug 3 17:57:55 2024 +0800 Fix linter errors commit 82b7561 Author: James Yu <[email protected]> Date: Sat Aug 3 17:56:37 2024 +0800 Add tests to queue module of compile commit 55e4c87 Author: James Yu <[email protected]> Date: Wed Jul 31 18:49:38 2024 +0800 Fix a find root in ws test as file glob order is not static commit e9d6ec5 Author: Jerome Lelong <[email protected]> Date: Fri Jul 26 07:37:21 2024 +0200 Update grammar files to jlelong/vscode-latex-basics@4795be4 commit bf2df7f Author: James Yu <[email protected]> Date: Mon Jul 22 00:56:18 2024 +0800 Fix James-Yu#4313 Include (arg) macro signature in package intellisense commit 53fdd38 Author: Jerome Lelong <[email protected]> Date: Mon Jul 8 15:52:47 2024 +0200 Update grammar files to jlelong/vscode-latex-basics@1deac8f
This reverts commit 5ae60c7.
Sorry for letting this slip. I'm super swamped right now, unfortunately. I'll try to do it soon. |
Continue the discussion #4305 (reply in thread).