Duplabel check run only once, wording change

src/components/cacher.ts

@@ -160,6 +160,7 @@ export class Cacher {
         this.promises[filePath] = this.updateAST(cache).then(() => {
             this.updateElements(cache)
         }).finally(() => {
+            lw.dupLabelDetector.run()
             this.caching--
             delete this.promises[filePath]
             lw.eventBus.fire(eventbus.FileParsed, filePath)
@@ -241,14 +242,13 @@ export class Cacher {
 
     private updateElements(cache: Cache) {
         const start = performance.now()
-        lw.completer.citation.update(cache.filePath, cache.content)
+        lw.completer.citation.parse(cache)
         // Package parsing must be before command and environment.
         lw.completer.package.parse(cache)
         lw.completer.reference.parse(cache)
         lw.completer.glossary.parse(cache)
         lw.completer.environment.parse(cache)
         lw.completer.command.parse(cache)
-        lw.duplicateLabels.run(cache.filePath)
         this.updateBibfiles(cache)
         const elapsed = performance.now() - start
         logger.log(`Updated elements in ${elapsed.toFixed(2)} ms: ${cache.filePath} .`)

src/components/duplabeldetector.ts

@@ -0,0 +1,89 @@
+import * as vscode from 'vscode'
+import * as path from 'path'
+import * as lw from '../lw'
+
+const duplicatedLabelsDiagnostics = vscode.languages.createDiagnosticCollection('Duplicate Labels')
+
+export const dupLabelDetector = {
+    run,
+    reset
+}
+
+/**
+ * Compute the dictionary of labels
+ */
+function computeDuplicates(): string[] {
+    const labelsCount = new Map<string, number>()
+    lw.cacher.getIncludedTeX().forEach(cachedFile => {
+        const cachedRefs = lw.cacher.get(cachedFile)?.elements.reference
+        if (cachedRefs === undefined) {
+            return
+        }
+        cachedRefs.forEach(ref => {
+            if (ref.range === undefined) {
+                return
+            }
+            let count = labelsCount.get(ref.label)
+            if (count === undefined) {
+                count = 0
+            }
+            count += 1
+            labelsCount.set(ref.label, count)
+        })
+    })
+    const duplicates = []
+    for (const [label, count] of labelsCount) {
+        if (count > 1) {
+            duplicates.push(label)
+        }
+    }
+    return duplicates
+}
+
+function run() {
+    const configuration = vscode.workspace.getConfiguration('latex-workshop')
+    if (!configuration.get('check.duplicatedLabels.enabled')) {
+        return
+    }
+    const duplicates = computeDuplicates()
+    showDiagnostics(duplicates)
+}
+
+function showDiagnostics(duplicates: string[]) {
+    duplicatedLabelsDiagnostics.clear()
+    if (duplicates.length === 0) {
+        return
+    }
+    const diagsCollection = Object.create(null) as { [key: string]: vscode.Diagnostic[] }
+
+    lw.cacher.getIncludedTeX().forEach(cachedFile => {
+        const cachedRefs = lw.cacher.get(cachedFile)?.elements.reference
+        if (cachedRefs === undefined) {
+            return
+        }
+        cachedRefs.forEach(ref => {
+            if (ref.range === undefined) {
+                return
+            }
+            if (duplicates.includes(ref.label)) {
+                if (! (cachedFile in diagsCollection)) {
+                    diagsCollection[cachedFile] = []
+                }
+                const range = ref.range instanceof vscode.Range ? ref.range : ref.range.inserting
+                const diag = new vscode.Diagnostic(range, `Duplicate label ${ref.label}`, vscode.DiagnosticSeverity.Warning)
+                diag.source = 'DuplicateLabels'
+                diagsCollection[cachedFile].push(diag)
+            }
+        })
+    })
+
+    for (const file in diagsCollection) {
+        if (path.extname(file) === '.tex') {
+            duplicatedLabelsDiagnostics.set(vscode.Uri.file(file), diagsCollection[file])
+        }
+    }
+}
+
+function reset() {
+    duplicatedLabelsDiagnostics.clear()
+}

src/components/manager.ts

@@ -303,7 +303,7 @@ export class Manager {
 
                 // We also clean the completions from the old project
                 lw.completer.input.reset()
-                lw.duplicateLabels.reset()
+                lw.dupLabelDetector.reset()
                 lw.cacher.src.reset()
                 lw.cacher.add(rootFile)
                 void lw.cacher.refreshCache(rootFile).then(async () => {

src/lw.ts

@@ -6,7 +6,7 @@ import { Cleaner } from './components/cleaner'
 import { LaTeXCommanderTreeView } from './components/commander'
 import { Configuration } from './components/configuration'
 import { Counter } from './components/counter'
-import { DuplicateLabels } from './components/duplicatelabels'
+export { dupLabelDetector } from './components/duplabeldetector'
 import { EnvPair } from './components/envpair'
 import { EventBus } from './components/eventbus'
 import { Linter } from './components/linter'
@@ -55,7 +55,6 @@ export const server = new Server()
 export const locator = new Locator()
 export const completer = new Completer()
 export const atSuggestionCompleter = new AtSuggestionCompleter()
-export const duplicateLabels = new DuplicateLabels()
 export const linter = new Linter()
 export const cleaner = new Cleaner()
 export const counter = new Counter()

src/providers/completer/citation.ts

@@ -8,6 +8,7 @@ import {computeFilteringRange} from './completerutils'
 import type { IProvider, ICompletionItem, IProviderArgs } from '../completion'
 import { getLogger } from '../../components/logger'
 import { parser } from '../../components/parser'
+import { Cache } from '../../components/cacher'
 
 const logger = getLogger('Intelli', 'Citation')
 
@@ -342,18 +343,12 @@ export class Citation implements IProvider {
     }
 
     /**
-     * Updates the Manager cache for bibitems defined in `file`.
-     * `content` is parsed with regular expressions,
-     * and the result is used to update the cache.
-     *
-     * @param file The path of a LaTeX file.
-     * @param content The content of a LaTeX file.
+     * Updates the Manager cache for bibitems with Cache.
+     * Cache `content` is parsed with regular expressions,
+     * and the result is used to update the cache bibitem element.
      */
-    update(file: string, content: string) {
-        const cache = lw.cacher.get(file)
-        if (cache !== undefined) {
-            cache.elements.bibitem = this.parseContent(file, content)
-        }
+    parse(cache: Cache) {
+        cache.elements.bibitem = this.parseContent(cache.filePath, cache.content)
     }
 
     private parseContent(file: string, content: string): CiteSuggestion[] {

test/suites/utils.ts

@@ -79,7 +79,7 @@ export async function reset() {
     lw.manager.rootFile = undefined
     lw.manager.localRootFile = undefined
     lw.completer.input.reset()
-    lw.duplicateLabels.reset()
+    lw.dupLabelDetector.reset()
     lw.cacher.reset()
     glob.sync('**/{**.tex,**.pdf,**.bib}', { cwd: getFixture() }).forEach(file => { try {fs.unlinkSync(path.resolve(getFixture(), file))} catch {} })
 }