Add --custom-function parameter to check. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2018 14:59
|
This will fix the issue #33. |
JakubOnderka
reviewed
Jan 5, 2019
.gitignore
Outdated
| /composer.lock | ||
| .idea |
There was a problem hiding this comment.
Can you please revert that change? .idea folder is IDE specific and you should ignore it thought global gitignore.
JakubOnderka
requested changes
Jan 5, 2019
README.md
Outdated
| @@ -48,6 +48,7 @@ Options for run | |||
| - `--doctrine` - check dump: `Doctrine::dump`, `\Doctrine\Common\Util\Debug::dump` | |||
| - `--symfony` - check dump: `dump`, `VarDumper::dump`, `VarDumper::setHandler` | |||
| - `--laravel` - check dump: `dd`, `dump` | |||
| - `--custom-function` - comma separated custom function name(s) to check like "pre_echo" | |||
There was a problem hiding this comment.
Please use ` instead of " to match other parameters description
src/Settings.php
Outdated
| @@ -131,6 +136,13 @@ public static function parseArguments(array $arguments) | |||
| } | |||
| } | |||
| $setting->functionsToCheck = array_unique($setting->functionsToCheck); | |||
|
|
|||
| // Any custom function is given | |||
| if (count($customFunctions) > 0) { | |||
There was a problem hiding this comment.
empty is used instead of count($customFunctions) > 0
|
Thanks for your pull request, I am happy to add that functionality after you resolve conflict and requested changes. Thanks! When this will be merged, I will release a new version. |
|
Is this mergable ? |
@kl3sk Technically yes, but I think the owner of the repo is a bit busy for a while. |
|
Ok, I didn't know it. Wait for it. |
Using the caret is the recommended manner of setting a version requirement.
Array access using curly braces has been deprecated in PHP 7.4. Ref: https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
Caused by the review message in the following link. php-parallel-lint/PHP-Var-Dump-Check#6 (comment)
Using the caret is the recommended manner of setting a version requirement.
Array access using curly braces has been deprecated in PHP 7.4. Ref: https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
Caused by the review message in the following link. php-parallel-lint/PHP-Var-Dump-Check#6 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of the projects that I have been working for a while, there are some legacy dump functions created and used frequently by the team. A sample function is;
function pre_dump( $var ) { echo '<pre>'; var_dump( $var ); echo '</pre>'; }The check can not be able to find the usage of this kind of functions. With this pull request, user can give the names of such kind of custom debug functions to the check function with "--custom-function" parameter.