Make YAML storage loading safer and able to catch errors #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents arbitrary code execution from access to config files using tags like !!python/object/apply:os.system and in the process sets up some infrastructure for eventually switching to storage using custom tags that does not use python/object. It does, however, need a bit of yaml constructor spaghetti to parse some of the datatypes that can't simply inherit from SafeYAMLObject.
This prevents storage loading from erroring out when loading an old storage that references classes that no longer exist. (vspreview may still error out later when it gets None in places where it doesn't expect it, but that can then be handled with additional checks) This fixes one of the two causes of crashes due to outdated storage files (the other one being aliases in the local storage pointing to removed fields in the global storage).
This fixes the second set of crashes due to outdated config files. One unfortunate consequence is that we can no longer use the C loaders, since we need to override methods. If this has a noticable performance impact, one could first try loading using the C loader and then fall back to the loader wrapper in the case of errors. Also, some of this code no longer feels like it belongs in bases.py but oh well.
arch1t3cht
changed the title
LightArrowsEXE
merged commit 7c24aa8
into
Jaded-Encoding-Thaumaturgy:master
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for more information.