Remove aria-multiselectable; Close oncode#37

JacobDB · Aug 14, 2024 · c81408b · c81408b
1 parent 291c376
commit c81408b
Show file tree

Hide file tree

Showing 9 changed files with 5 additions and 85 deletions.
diff --git a/docs/js/demo.bundle.js b/docs/js/demo.bundle.js
@@ -618,7 +618,6 @@
       _this.options = Object.assign({}, Handorgel.defaultOptions, options);
       _this._listeners = {};
       _this._bindEvents();
-      _this._initAria();
       _this.update();
       return _this;
     }
@@ -684,7 +683,6 @@
           fold.destroy();
         });
         this._unbindEvents();
-        this._cleanAria();
 
         // clean reference to handorgel instance
         this.element.handorgel = null;
@@ -702,21 +700,6 @@
           }
         });
       }
-    }, {
-      key: "_initAria",
-      value: function _initAria() {
-        if (!this.options.ariaEnabled) {
-          return;
-        }
-        if (this.options.multiSelectable) {
-          this.element.setAttribute('aria-multiselectable', 'true');
-        }
-      }
-    }, {
-      key: "_cleanAria",
-      value: function _cleanAria() {
-        this.element.removeAttribute('aria-multiselectable');
-      }
     }, {
       key: "_bindEvents",
       value: function _bindEvents() {

diff --git a/lib/js/esm/handorgel.js b/lib/js/esm/handorgel.js
@@ -616,7 +616,6 @@ var Handorgel = /*#__PURE__*/function (_EventEmitter) {
     _this.options = Object.assign({}, Handorgel.defaultOptions, options);
     _this._listeners = {};
     _this._bindEvents();
-    _this._initAria();
     _this.update();
     return _this;
   }
@@ -682,7 +681,6 @@ var Handorgel = /*#__PURE__*/function (_EventEmitter) {
         fold.destroy();
       });
       this._unbindEvents();
-      this._cleanAria();
 
       // clean reference to handorgel instance
       this.element.handorgel = null;
@@ -700,21 +698,6 @@ var Handorgel = /*#__PURE__*/function (_EventEmitter) {
         }
       });
     }
-  }, {
-    key: "_initAria",
-    value: function _initAria() {
-      if (!this.options.ariaEnabled) {
-        return;
-      }
-      if (this.options.multiSelectable) {
-        this.element.setAttribute('aria-multiselectable', 'true');
-      }
-    }
-  }, {
-    key: "_cleanAria",
-    value: function _cleanAria() {
-      this.element.removeAttribute('aria-multiselectable');
-    }
   }, {
     key: "_bindEvents",
     value: function _bindEvents() {

diff --git a/lib/js/esm/handorgel.min.js b/lib/js/esm/handorgel.min.js
diff --git a/lib/js/handorgel.js b/lib/js/handorgel.js
@@ -450,7 +450,6 @@ class Handorgel extends evEmitter {
     this.options = Object.assign({}, Handorgel.defaultOptions, options);
     this._listeners = {};
     this._bindEvents();
-    this._initAria();
     this.update();
   }
   update() {
@@ -509,7 +508,6 @@ class Handorgel extends evEmitter {
       fold.destroy();
     });
     this._unbindEvents();
-    this._cleanAria();
 
     // clean reference to handorgel instance
     this.element.handorgel = null;
@@ -525,17 +523,6 @@ class Handorgel extends evEmitter {
       }
     });
   }
-  _initAria() {
-    if (!this.options.ariaEnabled) {
-      return;
-    }
-    if (this.options.multiSelectable) {
-      this.element.setAttribute('aria-multiselectable', 'true');
-    }
-  }
-  _cleanAria() {
-    this.element.removeAttribute('aria-multiselectable');
-  }
   _bindEvents() {
     this._listeners.foldOpen = this._handleFoldOpen.bind(this);
     this.on('fold:open', this._listeners.foldOpen);

diff --git a/lib/js/handorgel.min.js b/lib/js/handorgel.min.js
diff --git a/lib/js/umd/handorgel.js b/lib/js/umd/handorgel.js
@@ -622,7 +622,6 @@
       _this.options = Object.assign({}, Handorgel.defaultOptions, options);
       _this._listeners = {};
       _this._bindEvents();
-      _this._initAria();
       _this.update();
       return _this;
     }
@@ -688,7 +687,6 @@
           fold.destroy();
         });
         this._unbindEvents();
-        this._cleanAria();
 
         // clean reference to handorgel instance
         this.element.handorgel = null;
@@ -706,21 +704,6 @@
           }
         });
       }
-    }, {
-      key: "_initAria",
-      value: function _initAria() {
-        if (!this.options.ariaEnabled) {
-          return;
-        }
-        if (this.options.multiSelectable) {
-          this.element.setAttribute('aria-multiselectable', 'true');
-        }
-      }
-    }, {
-      key: "_cleanAria",
-      value: function _cleanAria() {
-        this.element.removeAttribute('aria-multiselectable');
-      }
     }, {
       key: "_bindEvents",
       value: function _bindEvents() {

diff --git a/lib/js/umd/handorgel.min.js b/lib/js/umd/handorgel.min.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/js/index.js b/src/js/index.js
@@ -21,7 +21,6 @@ export default class Handorgel extends EventEmitter {
     this._listeners = {}
 
     this._bindEvents()
-    this._initAria()
     this.update()
   }
 
@@ -100,7 +99,6 @@ export default class Handorgel extends EventEmitter {
     })
 
     this._unbindEvents()
-    this._cleanAria()
 
     // clean reference to handorgel instance
     this.element.handorgel = null
@@ -119,20 +117,6 @@ export default class Handorgel extends EventEmitter {
     })
   }
 
-  _initAria() {
-    if (!this.options.ariaEnabled) {
-      return
-    }
-
-    if (this.options.multiSelectable) {
-      this.element.setAttribute('aria-multiselectable', 'true')
-    }
-  }
-
-  _cleanAria() {
-    this.element.removeAttribute('aria-multiselectable')
-  }
-
   _bindEvents() {
     this._listeners.foldOpen = this._handleFoldOpen.bind(this)
     this.on('fold:open', this._listeners.foldOpen)