Feat(Problem): 문제 세트 조회 API 구현 (SWM-45) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 문제 랜덤 조회 쿼리는 native query로 구현 - Problem에서 Exam과 Subject를 EAGER로 설정 - Problem의 Exception 관련 코드 구현
- UseCase에서 로직 구현에도 stream을 더욱 적극 활용하도록 변경
InHyeok-J
reviewed
Jun 25, 2024
Comment on lines
+46
to
56
| return subjectIds.stream() | ||
| .map(subjectId -> { | ||
| if (examId.isPresent()) { | ||
| return problemRepository.findRandomByExamIdAndSubjectId(examId.get(), subjectId, count); | ||
| } | ||
| return problemRepository.findRandomBySubjectId(subjectId, count); | ||
| }) | ||
| .flatMap(List::stream) | ||
| .map(FindProblemsResponse::from) | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
db 접근 로직이랑 / List 응답 맵핑 Stream을 분리할 수 없나요?
가독성 + 유지보수에 어려울 것 같아서요
There was a problem hiding this comment.
네 수정했습니다~
다음 PR에 올릴게요~!
morenow98
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 변경된 내용
추가 내용
참조
Jira Issue: SWM-45