Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(Auth): OIDC 기반 GoogleLogin 구현 #45

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

InHyeok-J
Copy link
Contributor

PR 변경된 내용

  • OIDC 기반 구글 로그인 구현
  • 로직
    /*  Google Public Key를 받는 로직
     *  1. https://accounts.google.com/.well-known/openid-configuration -> jwks_uri 값을 파싱해온다.
     *  2. jwks_uri 으로 API를 호출해서 Public Key에 대한 응답 값을 받는다
     *  1번과 2번의 모든 결과는 캐싱을 해야 한다.
     *  Ref: https://developers.google.com/identity/openid-connect/openid-connect?hl=ko#validatinganidtoken
     */
  • openid-configuartion은 restclient + interface 형식으로 구성
  • jwk을 호출하는 api는 직접 호출해야 하기 때문에 직접 구현 클래스 작성
  • 두 API 결과값 모두 캐싱( 일단 저번처럼 1일 )

추가 내용

  • RedisCache에 중복되는 코드가 있는데 해당 부분은 따로 리팩토링 하겠습니다..

참조

Closes #42

@InHyeok-J InHyeok-J requested a review from morenow98 July 29, 2024 08:06
@InHyeok-J InHyeok-J self-assigned this Jul 29, 2024
Copy link
Member

@morenow98 morenow98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@InHyeok-J InHyeok-J merged commit da3bf8c into develop Jul 29, 2024
1 check passed
@InHyeok-J InHyeok-J deleted the feature/42-googlelogin branch September 9, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google 회원가입 처리
2 participants