-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(SignUp): 카카오 회원가입, jwt 로그인 구현 #21
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- getter 기반 메소드 호출로 변경 - memberfactory의 파라미터 수정
morenow98
requested changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OIDC 쪽 코드를 너무 잘 짜신 것 같아요! 밑에 질문드린 게 좀 많지만,,,,
LGTM😁
jabiseo-api/src/main/java/com/jabiseo/auth/application/usecase/LoginUseCase.java
Outdated
Show resolved
Hide resolved
jabiseo-api/src/main/java/com/jabiseo/auth/application/oidc/TokenValidatorManager.java
Outdated
Show resolved
Hide resolved
jabiseo-api/src/main/java/com/jabiseo/auth/application/oidc/KakaoIdTokenValidator.java
Outdated
Show resolved
Hide resolved
jabiseo-infrastructure/src/main/java/com/jabiseo/cache/RedisCacheRepository.java
Show resolved
Hide resolved
jabiseo-api/src/main/java/com/jabiseo/auth/application/oidc/KakaoIdTokenValidator.java
Outdated
Show resolved
Hide resolved
jabiseo-api/src/main/java/com/jabiseo/auth/application/usecase/LoginUseCase.java
Outdated
Show resolved
Hide resolved
jabiseo-common/src/main/java/com/jabiseo/exception/ErrorCode.java
Outdated
Show resolved
Hide resolved
jabiseo-domain/src/main/java/com/jabiseo/member/domain/RandomNicknameGenerator.java
Show resolved
Hide resolved
- 스트림 람다 기반 로직 처리로 변경
morenow98
reviewed
Jul 13, 2024
jabiseo-api/src/main/java/com/jabiseo/common/ValueOfEnumValidator.java
Outdated
Show resolved
Hide resolved
jabiseo-api/src/test/java/com/jabiseo/auth/application/usecase/LoginUseCaseTest.java
Show resolved
Hide resolved
jabiseo-api/src/test/java/com/jabiseo/auth/dto/LoginRequestTest.java
Outdated
Show resolved
Hide resolved
jabiseo-infrastructure/src/main/java/com/jabiseo/client/RestClientConfig.java
Show resolved
Hide resolved
morenow98
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 변경된 내용
추가 내용
참조
Test 추가 내용
DTO 검증
kakaoClient에 대한 예외처리
논의가 필요한 내용
Closed: #20